Skip to content

Add Context.getSystemServiceAs extension#3451

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
developfrom
dd-sdk-android-context-ext
May 18, 2026
Merged

Add Context.getSystemServiceAs extension#3451
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
developfrom
dd-sdk-android-context-ext

Conversation

@satween

@satween satween commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Context.getSystemServiceAs<T>(name) in dd-sdk-android-internal
and migrates 13 call sites in core, internal, profiling, RUM, and
session-replay to use it.

@satween
satween changed the base branch from develop to tvaleev/feature/RUM-3862 May 15, 2026 15:43
@codecov-commenter

codecov-commenter commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.16%. Comparing base (b0b090e) to head (5f09bb2).

Files with missing lines Patch % Lines
...lin/com/datadog/android/rum/internal/RumFeature.kt 33.33% 0 Missing and 2 partials ⚠️
...droid/rum/internal/vitals/FrameStatesAggregator.kt 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3451      +/-   ##
===========================================
+ Coverage    72.13%   72.16%   +0.03%     
===========================================
  Files          963      964       +1     
  Lines        35485    35497      +12     
  Branches      5906     5896      -10     
===========================================
+ Hits         25595    25615      +20     
+ Misses        8270     8265       -5     
+ Partials      1620     1617       -3
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 86.98% <100.00%> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 96.88% <100.00%> (+1.00%) ⬆️
...e/internal/net/info/CallbackNetworkInfoProvider.kt 95.29% <100.00%> (-0.11%) ⬇️
...roid/core/internal/net/info/CarrierInfoResolver.kt 100.00% <ø> (ø)
...rnal/system/BroadcastReceiverSystemInfoProvider.kt 96.55% <100.00%> (ø)
...core/internal/system/DefaultAndroidInfoProvider.kt 71.74% <100.00%> (+1.85%) ⬆️
...a/com/datadog/android/internal/utils/ContextExt.kt 100.00% <100.00%> (ø)
...va/com/datadog/android/rum/DdRumContentProvider.kt 87.50% <100.00%> (ø)
...og/android/profiling/DdProfilingContentProvider.kt 51.72% <100.00%> (+0.11%) ⬆️
...domain/accessibility/DefaultAccessibilityReader.kt 100.00% <100.00%> (+1.12%) ⬆️
... and 4 more

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween force-pushed the dd-sdk-android-context-ext branch from b715ffd to 293e652 Compare May 15, 2026 16:19
@satween
satween marked this pull request as ready for review May 15, 2026 16:19
@satween
satween requested review from a team as code owners May 15, 2026 16:19
@satween satween changed the title RUM-3862 Add carrier info and Context.getSystemServiceAs extension Add Context.getSystemServiceAs extension May 15, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 15, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 293e652e32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/ContextExt.kt
kikoveiga
kikoveiga previously approved these changes May 15, 2026
View reviewed changes
0xnm
0xnm previously approved these changes May 18, 2026
View reviewed changes
jonathanmos
jonathanmos previously approved these changes May 18, 2026
View reviewed changes
Base automatically changed from tvaleev/feature/RUM-3862 to develop May 18, 2026 12:39
@satween
satween dismissed stale reviews from jonathanmos, 0xnm, and kikoveiga May 18, 2026 12:39

The base branch was changed.

@satween
satween requested a review from kikoveiga May 18, 2026 12:41
@satween
satween force-pushed the dd-sdk-android-context-ext branch from 293e652 to 5f09bb2 Compare May 18, 2026 12:45
@satween

satween commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-18 12:48:30 UTC ℹ️ Start processing command /merge

2026-05-18 12:48:36 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-05-18 13:48:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 56m (p90).

2026-05-18 14:45:11 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2229525 into develop May 18, 2026
28 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dd-sdk-android-context-ext branch May 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@0xnm 0xnm 0xnm approved these changes
@kikoveiga kikoveiga kikoveiga approved these changes
@jonathanmos jonathanmos jonathanmos left review comments

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@satween @codecov-commenter @0xnm @jonathanmos @kikoveiga