Skip to content

Bump ktlint and detekt versions#3444

Merged
kikoveiga merged 1 commit into
developfrom
kikoveiga/bump-ktlint-and-detekt-versions
May 15, 2026
Merged

Bump ktlint and detekt versions#3444
kikoveiga merged 1 commit into
developfrom
kikoveiga/bump-ktlint-and-detekt-versions

Conversation

@kikoveiga

@kikoveiga kikoveiga commented May 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Bumps ktlint and detekt versions to 1.5.0 and 1.23.8.
  • Updates static-analysis.yml version.

Motivation

Update old versions and align with dd-sdk-android-gradle-plugin.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween satween left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some instruction for detekt version migration for the local setups on the developers machines

@kikoveiga
kikoveiga force-pushed the kikoveiga/bump-ktlint-and-detekt-versions branch from 622e26e to 211b6f2 Compare May 14, 2026 13:00
@kikoveiga

Copy link
Copy Markdown
Contributor Author

It would be nice to have some instruction for detekt version migration for the local setups on the developers machines

@satween Thanks for the suggestion! Added that on local_ci.sh --setup step so now it will always install the correct versions used in the repo.

@kikoveiga
kikoveiga marked this pull request as ready for review May 14, 2026 13:02
@kikoveiga
kikoveiga requested review from a team as code owners May 14, 2026 13:02
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.04%. Comparing base (2f047a4) to head (211b6f2).

Files with missing lines Patch % Lines
...dog/android/core/internal/persistence/BatchData.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3444      +/-   ##
===========================================
- Coverage    72.07%   72.04%   -0.03%     
===========================================
  Files          961      961              
  Lines        35400    35401       +1     
  Branches      5883     5883              
===========================================
- Hits         25513    25502      -11     
- Misses        8270     8290      +20     
+ Partials      1617     1609       -8     
Files with missing lines Coverage Δ
...datadog/android/internal/network/GraphQLHeaders.kt 0.00% <ø> (ø)
...id/sessionreplay/internal/utils/InvocationUtils.kt 92.86% <100.00%> (ø)
...order/mapper/BaseAsyncBackgroundWireframeMapper.kt 94.83% <ø> (ø)
...dog/android/core/internal/persistence/BatchData.kt 66.67% <0.00%> (-3.92%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga
kikoveiga merged commit c879bbc into develop May 15, 2026
27 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/bump-ktlint-and-detekt-versions branch May 15, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants