Skip to content

Sync Detekt configs with a static-analysis template version#3439

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/sync-detekt-config-files-with-pipeline-version
May 12, 2026
Merged

Sync Detekt configs with a static-analysis template version#3439
0xnm merged 1 commit into
developfrom
nogorodnikov/sync-detekt-config-files-with-pipeline-version

Conversation

@0xnm

@0xnm 0xnm commented May 12, 2026

Copy link
Copy Markdown
Member

What does this PR do?

It is quite painful to get the right version of the Detekt Common and Public API config when working with dd-source in parallel, so this change does the following:

  • reads template version from CI pipeline definition
  • checks if it matches the version in the .stamp file of config folder
  • if it matches, and both config files are there (also in config folder), then run Detekt check
  • if version is different, then checkout dd-source at the right version and copy the necessary configs, restore dd-source back.

The code is 100% AI-generated, I'm not that big Bash/Git expert.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 12, 2026 15:34

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e90c194fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread local_ci.sh
@0xnm
0xnm force-pushed the nogorodnikov/sync-detekt-config-files-with-pipeline-version branch from 1e90c19 to a3309a6 Compare May 12, 2026 15:47
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.04%. Comparing base (38daa7d) to head (a3309a6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3439      +/-   ##
===========================================
- Coverage    72.05%   72.04%   -0.01%     
===========================================
  Files          961      961              
  Lines        35399    35399              
  Branches      5882     5882              
===========================================
- Hits         25506    25503       -3     
- Misses        8274     8283       +9     
+ Partials      1619     1613       -6     

see 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on my machine (even inside worktrees), thank you!

@0xnm
0xnm merged commit 80d1118 into develop May 12, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/sync-detekt-config-files-with-pipeline-version branch May 12, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants