RUM-16092: Atomically write NDK crash logs + catch NumberFormatException#3425
Merged
kikoveiga merged 2 commits intoMay 26, 2026
Merged
Conversation
kikoveiga
force-pushed
the
kikoveiga/rum-16092/catch-NumberFormatException
branch
2 times, most recently
from
May 8, 2026 15:22
d460c7b to
7853e1c
Compare
kikoveiga
marked this pull request as ready for review
May 8, 2026 15:26
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3425 +/- ##
===========================================
+ Coverage 72.20% 72.26% +0.06%
===========================================
Files 964 964
Lines 35554 35561 +7
Branches 5922 5922
===========================================
+ Hits 25669 25696 +27
+ Misses 8269 8256 -13
+ Partials 1616 1609 -7
🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
May 11, 2026
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
While it prevents SDK from crashing, the underlying problem stays - we don't still know why it happens.
If you check this telemetry, you will find more errors, which may be related.
Do you plan any further investigation?
jonathanmos
previously approved these changes
May 13, 2026
ambushwork
previously approved these changes
May 26, 2026
kikoveiga
dismissed stale reviews from ambushwork, jonathanmos, and 0xnm
via
May 26, 2026 15:07
2534bd3
kikoveiga
force-pushed
the
kikoveiga/rum-16092/catch-NumberFormatException
branch
from
May 26, 2026 15:07
7853e1c to
2534bd3
Compare
This comment has been minimized.
This comment has been minimized.
kikoveiga
changed the title
NumberFormatException
kikoveiga
changed the title
NumberFormatExceptionNumberFormatException
0xnm
previously approved these changes
May 26, 2026
kikoveiga
force-pushed
the
kikoveiga/rum-16092/catch-NumberFormatException
branch
from
May 26, 2026 16:14
2534bd3 to
2a2abf5
Compare
0xnm
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
write_crash_reportto an atomic write +fsync+renamepattern, so the NDKcrash_logfile on disk is never observable as zero-filled or torn when the process dies between the buffered write and the kerne's writeback (root cause of theNumberFormatException).catch (e: NumberFormatException)inNdkCrashLogDeserializerso corrupt files are handled gracefully.Review checklist (to be filled by reviewers)