Skip to content

RUM-15352: Replace GraphQL chain wrapper with request tag#3424

Merged
kikoveiga merged 2 commits into
developfrom
kikoveiga/rum-15352/replace-graphql-chain-wrapper
May 11, 2026
Merged

RUM-15352: Replace GraphQL chain wrapper with request tag#3424
kikoveiga merged 2 commits into
developfrom
kikoveiga/rum-15352/replace-graphql-chain-wrapper

Conversation

@kikoveiga

Copy link
Copy Markdown
Contributor

What does this PR do?

Replace the existing logic of wrapChainWithoutDDHeaders with strip-and-tag step at DatadogInterceptor.interceptor().
Now GraphQL attributes travel though the pipeline in a Request.tag().

Motivation

The previous logic was unpredictably modifying the request flow and could cause issues in complex interception pipelines. Also as tags are in-memory only, they cannot be serialized and leak to the network.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga
kikoveiga force-pushed the kikoveiga/rum-15352/replace-graphql-chain-wrapper branch from 124350b to c04c3d0 Compare May 8, 2026 14:02
@kikoveiga
kikoveiga marked this pull request as ready for review May 8, 2026 14:27
@kikoveiga
kikoveiga requested review from a team as code owners May 8, 2026 14:27
@codecov-commenter

codecov-commenter commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.06%. Comparing base (90d2c73) to head (fa43fc1).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3424      +/-   ##
===========================================
- Coverage    72.26%   72.06%   -0.20%     
===========================================
  Files          961      961              
  Lines        35418    35399      -19     
  Branches      5883     5882       -1     
===========================================
- Hits         25593    25508      -85     
- Misses        8235     8276      +41     
- Partials      1590     1615      +25     
Files with missing lines Coverage Δ
...id/okhttp/internal/graphql/OkHttpGraphQLAdapter.kt 85.29% <100.00%> (+21.83%) ⬆️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 81.03% <90.00%> (+0.46%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga self-assigned this May 8, 2026
0xnm
0xnm previously approved these changes May 11, 2026
@kikoveiga
kikoveiga merged commit 38daa7d into develop May 11, 2026
27 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/rum-15352/replace-graphql-chain-wrapper branch May 11, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants