Skip to content

RUM-15137: Don't run Java API generation task on CI for non-release builds#3421

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15137/stop-running-java-api-generation-for-non-release-builds-on-ci
May 5, 2026
Merged

RUM-15137: Don't run Java API generation task on CI for non-release builds#3421
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15137/stop-running-java-api-generation-for-non-release-builds-on-ci

Conversation

@0xnm

@0xnm 0xnm commented May 5, 2026

Copy link
Copy Markdown
Member

What does this PR do?

We are using binary-compatibility-validator plugin to generate Java API surface in addition to the KotlinAPI surface (made by ourselves).

The problem is that it is running on any compilation, but it has a strong dependency on the release compilation, meaning that if we run debug variant compilation, we will also then trigger release variant compilation for our library modules.

This PR keeps having Java API surface generation for non-CI executions (we want it to be updated on the local changes), but for CI it is strictly wired to the release compilation.

➜  dd-sdk-android ✗ ./gradlew :dd-sdk-android-internal:compileDebugKotlin --dry-run | grep Release
:dd-sdk-android-internal:preReleaseBuild SKIPPED
:dd-sdk-android-internal:generateReleaseResValues SKIPPED
:dd-sdk-android-internal:generateReleaseResources SKIPPED
:dd-sdk-android-internal:packageReleaseResources SKIPPED
:dd-sdk-android-internal:processReleaseNavigationResources SKIPPED
:dd-sdk-android-internal:parseReleaseLocalResources SKIPPED
:dd-sdk-android-internal:generateReleaseRFile SKIPPED
:dd-sdk-android-internal:kspReleaseKotlin SKIPPED
:dd-sdk-android-internal:compileReleaseKotlin SKIPPED
:dd-sdk-android-internal:javaPreCompileRelease SKIPPED
:dd-sdk-android-internal:compileReleaseJavaWithJavac SKIPPED
➜  dd-sdk-android ✗ CI=true ./gradlew :dd-sdk-android-internal:compileDebugKotlin --dry-run | grep Release
// nothing printed

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (d320acd) to head (a4634a5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3421   +/-   ##
========================================
  Coverage    72.06%   72.06%           
========================================
  Files          961      961           
  Lines        35406    35406           
  Branches      5880     5880           
========================================
  Hits         25512    25512           
- Misses        8278     8282    +4     
+ Partials      1616     1612    -4     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm marked this pull request as ready for review May 5, 2026 14:25
@0xnm
0xnm requested review from a team as code owners May 5, 2026 14:25
kikoveiga
kikoveiga previously approved these changes May 5, 2026
Comment thread buildSrc/src/main/kotlin/com/datadog/gradle/plugin/apisurface/ApiSurfacePlugin.kt Outdated
@0xnm
0xnm force-pushed the nogorodnikov/rum-15137/stop-running-java-api-generation-for-non-release-builds-on-ci branch from 6df4293 to a4634a5 Compare May 5, 2026 14:54
@0xnm
0xnm requested a review from kikoveiga May 5, 2026 14:54
@0xnm
0xnm merged commit cd233c7 into develop May 5, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-15137/stop-running-java-api-generation-for-non-release-builds-on-ci branch May 5, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants