Skip to content

Cleanup in core and internal modules#3417

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/core-internal-cleanup-050526
May 5, 2026
Merged

Cleanup in core and internal modules#3417
0xnm merged 1 commit into
developfrom
nogorodnikov/core-internal-cleanup-050526

Conversation

@0xnm

@0xnm 0xnm commented May 5, 2026

Copy link
Copy Markdown
Member

What does this PR do?

A bit of cleanup suggested by IDE.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 5, 2026 09:19
@codecov-commenter

codecov-commenter commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.05%. Comparing base (cbd94a0) to head (1d18be2).

Files with missing lines Patch % Lines
...tadog/android/core/internal/NoOpInternalSdkCore.kt 0.00% 6 Missing ⚠️
...n/com/datadog/android/core/internal/DatadogCore.kt 75.00% 1 Missing ⚠️
...adog/android/internal/profiler/BenchmarkSpanExt.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3417   +/-   ##
========================================
  Coverage    72.05%   72.05%           
========================================
  Files          961      961           
  Lines        35407    35406    -1     
  Branches      5880     5880           
========================================
  Hits         25509    25509           
+ Misses        8287     8286    -1     
  Partials      1611     1611
Files with missing lines Coverage Δ
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 73.91% <ø> (ø)
.../main/kotlin/com/datadog/android/_InternalProxy.kt 62.50% <ø> (+2.50%) ⬆️
...src/main/kotlin/com/datadog/android/api/SdkCore.kt 20.00% <ø> (ø)
...tlin/com/datadog/android/api/context/DeviceInfo.kt 100.00% <ø> (ø)
...lin/com/datadog/android/api/context/NetworkInfo.kt 74.68% <ø> (ø)
.../kotlin/com/datadog/android/api/feature/Feature.kt 100.00% <ø> (ø)
...com/datadog/android/api/feature/FeatureScopeExt.kt 0.00% <ø> (ø)
.../com/datadog/android/api/feature/FeatureSdkCore.kt 33.33% <ø> (ø)
...main/kotlin/com/datadog/android/api/net/Request.kt 100.00% <ø> (ø)
...droid/core/configuration/BackPressureMitigation.kt 100.00% <ø> (ø)
... and 20 more

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kikoveiga
kikoveiga previously approved these changes May 5, 2026
View reviewed changes
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureSdkCore.kt Outdated
@0xnm
0xnm force-pushed the nogorodnikov/core-internal-cleanup-050526 branch from caa5027 to 1d18be2 Compare May 5, 2026 09:54
@0xnm
0xnm requested a review from kikoveiga May 5, 2026 09:54
hamorillo
hamorillo approved these changes May 5, 2026
View reviewed changes

@hamorillo hamorillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@0xnm
0xnm merged commit d320acd into develop May 5, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/core-internal-cleanup-050526 branch May 5, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamorillo hamorillo hamorillo approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes
@kikoveiga kikoveiga kikoveiga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @hamorillo @jonathanmos @kikoveiga