Fix evaluation intake endpoint path#3414
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 4, 2026
Merged
Conversation
0xnm
approved these changes
May 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3414 +/- ##
===========================================
- Coverage 72.04% 71.99% -0.04%
===========================================
Files 960 960
Lines 35309 35309
Branches 5851 5856 +5
===========================================
- Hits 25435 25420 -15
- Misses 8276 8279 +3
- Partials 1598 1610 +12
🚀 New features to boost your workflow:
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
typo/fix-evaluation-endpoint-path
branch
May 4, 2026 17:31
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the evaluation intake endpoint path from
/api/v2/flagevaluations(plural) to/api/v2/flagevaluation(singular).Motivation
The plural form caused 404s because the backend track is defined as
flagevaluation(singular). This matches the endpoint used by browser-sdk and Unity SDK.Additional Notes
Changed the constant in
EvaluationsRequestFactory, updated the corresponding test assertion, and fixed stale KDoc comments in bothEvaluationsRequestFactoryandEvaluationsFeature.