Log task names for the observable queue dump in case of context executor usage#3412
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ebe1e05e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3412 +/- ##
========================================
Coverage 72.04% 72.04%
========================================
Files 960 960
Lines 35309 35315 +6
Branches 5851 5855 +4
========================================
+ Hits 25435 25440 +5
+ Misses 8276 8264 -12
- Partials 1598 1611 +13
🚀 New features to boost your workflow:
|
0xnm
force-pushed
the
nogorodnikov/log-task-names-in-context-executor
branch
from
May 4, 2026 11:58
9ebe1e0 to
3e52852
Compare
kikoveiga
approved these changes
May 4, 2026
jonathanmos
approved these changes
May 5, 2026
ambushwork
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now we are using
NamedRunnable/NamedCallableonly in RUM pipeline, meaning we don't have visibility for non-RUM queues.This PR adds them to the generic
submitSafeexecuteSafemethods since they already carryoperationName, so that we have more visibility when we hit backpressure.We won't wrap task if it already implements
NamedRunnable/NamedCallable.On top of that, limit the size of the queue when we are doing the copy. Queue may be unbounded (doing only notifications, like in case of context queue), so if we have too many items there copy becomes very heavy.
Note: this approach doesn't work for
submitcalls, because task get wrapped into another classes there (namelyFutureTaskat least).Review checklist (to be filled by reviewers)