Skip to content

RUM-15914: Drop word feature from operations APIs#3390

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15914/rename-feature-operations-apis
Apr 24, 2026
Merged

RUM-15914: Drop word feature from operations APIs#3390
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15914/rename-feature-operations-apis

Conversation

@0xnm

@0xnm 0xnm commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Change similar to DataDog/dd-sdk-ios#2802: we are changing the wording feature operations -> operations.

This PR deprecates feature-related symbol names, they should be removed in v4.

Also adding OperationOptions parameter, which will be used later for profiling.

cc @simaoseica-dd @Valpertui

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 22, 2026 14:16
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 22, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f24d91dcf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/RumMonitor.kt
Comment thread features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/RumMonitor.kt
@0xnm
0xnm force-pushed the nogorodnikov/rum-15914/rename-feature-operations-apis branch 3 times, most recently from 8ccd7c7 to 32ab0db Compare April 22, 2026 15:02
@codecov-commenter

codecov-commenter commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.99%. Comparing base (ec675d8) to head (32f7ded).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/monitor/DatadogRumMonitor.kt 69.57% 7 Missing ⚠️
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3390      +/-   ##
===========================================
- Coverage    72.27%   71.99%   -0.27%     
===========================================
  Files          956      958       +2     
  Lines        35307    35325      +18     
  Branches      5861     5862       +1     
===========================================
- Hits         25515    25431      -84     
- Misses        8222     8288      +66     
- Partials      1570     1606      +36
Files with missing lines Coverage Δ
...dog/android/rum/featureoperations/FailureReason.kt 0.00% <ø> (-100.00%) ⬇️
...g/android/rum/internal/domain/scope/RumEventExt.kt 92.80% <ø> (-2.73%) ⬇️
...g/android/rum/internal/domain/scope/RumRawEvent.kt 100.00% <ø> (ø)
...d/rum/internal/domain/scope/RumViewManagerScope.kt 93.15% <100.00%> (-0.40%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.86% <100.00%> (+0.10%) ⬆️
...om/datadog/android/rum/operations/FailureReason.kt 100.00% <100.00%> (ø)
...datadog/android/rum/operations/OperationOptions.kt 100.00% <100.00%> (ø)
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 28.57% <0.00%> (-11.43%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 86.98% <69.57%> (-1.52%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kikoveiga
kikoveiga previously approved these changes Apr 22, 2026
View reviewed changes

@kikoveiga kikoveiga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rename the ids named like fo_, button_fo, etc.

Also should we add a TODO RUM-13454 (v4) somewhere in the code or create a ticket to not forget to remove the deprecated stuff here?

Comment thread ...d-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/featureoperations/FailureReason.kt Outdated
@0xnm
0xnm force-pushed the nogorodnikov/rum-15914/rename-feature-operations-apis branch from 32ab0db to 32f7ded Compare April 23, 2026 06:39
@0xnm
0xnm requested review from kikoveiga and satween April 23, 2026 06:39
satween
satween reviewed Apr 24, 2026
View reviewed changes

@satween satween left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small minor changes comments only

Comment thread ...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
Comment thread ...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
Comment thread features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/RumMonitor.kt
@satween
satween self-requested a review April 24, 2026 15:38
@0xnm
0xnm merged commit 261867c into develop Apr 24, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-15914/rename-feature-operations-apis branch April 24, 2026 15:40
@kikoveiga kikoveiga mentioned this pull request Apr 28, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@satween satween satween approved these changes
@kikoveiga kikoveiga kikoveiga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @satween @kikoveiga