Skip to content

Change location of Play SDK console verification token in the published lib#3368

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/play-sdk-console-verification-130426
Apr 13, 2026
Merged

Change location of Play SDK console verification token in the published lib#3368
0xnm merged 1 commit into
developfrom
nogorodnikov/play-sdk-console-verification-130426

Conversation

@0xnm

@0xnm 0xnm commented Apr 13, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Follow-up for #3217, because the verification didn't work.

Right now verification.properties is in xxx.aar/classes.jar/META-INF, so with this change it will be in xxx.aar/META-INF instead.

Verification instructions simply say:

Unzip this file in your SDK's parent folder. Make sure the file verification.properties is located inside src/main/resources/META-INF/com/datadoghq/dd-sdk-android-glide

Build your SDK and ensure that the verification file is included in your binary

We followed them, it didn't work, so trying something else. Help link on the Play SDK console website doesn't work anyway.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 13, 2026 10:12
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.86%. Comparing base (e71690e) to head (ed1e44e).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3368      +/-   ##
===========================================
+ Coverage    71.49%   71.86%   +0.36%     
===========================================
  Files          947      947              
  Lines        34919    34919              
  Branches      5921     5801     -120     
===========================================
+ Hits         24965    25092     +127     
+ Misses        8290     8236      -54     
+ Partials      1664     1591      -73     

see 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit bc97e25 into develop Apr 13, 2026
28 checks passed
@0xnm
0xnm deleted the nogorodnikov/play-sdk-console-verification-130426 branch April 13, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants