Skip to content

Improve sample app's image libraries#3353

Merged
kikoveiga merged 1 commit into
developfrom
kikoveiga/improve-sample-app-image-libraries
Apr 10, 2026
Merged

Improve sample app's image libraries#3353
kikoveiga merged 1 commit into
developfrom
kikoveiga/improve-sample-app-image-libraries

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fix broken libraries (before, only Picasso was working correctly).
  • Add placeholder and error drawables to all libs.
  • Implement 3-tap cycle: real request -> cache hit -> 404 error.
  • Rename picture package to image and respective references.
  • Small improvements.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga
kikoveiga force-pushed the kikoveiga/improve-sample-app-image-libraries branch from d239fb5 to e18a060 Compare April 9, 2026 16:01
@datadog-official

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.81%. Comparing base (e71690e) to head (2d59f12).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3353      +/-   ##
===========================================
+ Coverage    71.49%   71.81%   +0.32%     
===========================================
  Files          947      947              
  Lines        34919    34919              
  Branches      5921     5801     -120     
===========================================
+ Hits         24965    25077     +112     
+ Misses        8290     8250      -40     
+ Partials      1664     1592      -72     

see 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga self-assigned this Apr 10, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/improve-sample-app-image-libraries branch 2 times, most recently from c747f93 to 38ee1a9 Compare April 10, 2026 15:13
@kikoveiga
kikoveiga force-pushed the kikoveiga/improve-sample-app-image-libraries branch from 38ee1a9 to 2d59f12 Compare April 10, 2026 15:18
@kikoveiga
kikoveiga marked this pull request as ready for review April 10, 2026 15:18
@kikoveiga
kikoveiga requested review from a team as code owners April 10, 2026 15:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d59f126c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kikoveiga
kikoveiga merged commit d19a14a into develop Apr 10, 2026
28 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/improve-sample-app-image-libraries branch April 10, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants