Skip to content

RUM-517: Remove kapt by bumping glide version#3351

Merged
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-517/remove-kapt
Apr 10, 2026
Merged

RUM-517: Remove kapt by bumping glide version#3351
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-517/remove-kapt

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Bump glide from 4.11.0 to 5.0.5, enabling the usage of ksp instead of kapt. The APIs used by dd-sdk-android-glide are unchanged in v5, so there is no behavioral impact. Binary compatibility for new glide v5 (minSdk 14, Java 8) is still below the project's minSdk 23 and Java 11.
  • Minor fixes.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga changed the title RUM-517: Remove kapt RUM-517: Remove kapt by bumping glide version Apr 9, 2026
@kikoveiga
kikoveiga marked this pull request as ready for review April 9, 2026 13:09
@kikoveiga
kikoveiga requested review from a team as code owners April 9, 2026 13:09
Comment thread gradle/libs.versions.toml
Comment thread integrations/dd-sdk-android-glide/build.gradle.kts Outdated
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-517/remove-kapt branch from 647ea3e to 7126fb4 Compare April 9, 2026 13:31
@kikoveiga
kikoveiga requested a review from 0xnm April 9, 2026 13:31
@datadog-prod-us1-6

This comment has been minimized.

@kikoveiga kikoveiga self-assigned this Apr 9, 2026
@codecov-commenter

codecov-commenter commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.87%. Comparing base (d19a14a) to head (bbbdedb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3351      +/-   ##
===========================================
+ Coverage    71.87%   71.87%   +0.01%     
===========================================
  Files          947      947              
  Lines        34919    34919              
  Branches      5801     5801              
===========================================
+ Hits         25096    25098       +2     
- Misses        8231     8238       +7     
+ Partials      1592     1583       -9     
Files with missing lines Coverage Δ
...in/com/datadog/android/glide/DatadogGlideModule.kt 95.65% <ø> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-517/remove-kapt branch 2 times, most recently from 4751e74 to 5dcf3d7 Compare April 9, 2026 14:28
Comment thread integrations/dd-sdk-android-okhttp/build.gradle.kts Outdated
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-517/remove-kapt branch from 5dcf3d7 to 31895f8 Compare April 10, 2026 15:21
@kikoveiga
kikoveiga requested a review from 0xnm April 10, 2026 15:22
0xnm
0xnm previously approved these changes Apr 10, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-517/remove-kapt branch from 31895f8 to bbbdedb Compare April 10, 2026 16:18
@kikoveiga
kikoveiga requested a review from 0xnm April 10, 2026 16:19
@kikoveiga
kikoveiga merged commit 1977618 into develop Apr 10, 2026
27 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/RUM-517/remove-kapt branch April 10, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants