RUM-15544: DatadogTracingToolkit.kt -> _TraceInternalProxy by satween · Pull Request #3350 · DataDog/dd-sdk-android

satween · 2026-04-09T11:21:27Z

What does this PR do?

Renaming DatadogTracingToolkit.kt to _TraceInternalProxy in order to make it consistent with existing _RumInternalProxy and InternalProxy classes

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e969c3609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T11:25:04Z

+  constructor(() -> com.datadog.android.api.feature.FeatureSdkCore?)
+  companion object 
+    fun com.datadog.android.trace.api.span.DatadogSpan.extractRumContext(RumContextPropagator, Boolean = false)
+object com.datadog.android.trace.internal._TraceInternalProxy


Regenerate trace Java API dump after proxy rename

This rename updates apiSurface to com.datadog.android.trace.internal._TraceInternalProxy, but the paired Java ABI file (features/dd-sdk-android-trace/api/dd-sdk-android-trace.api) still declares DatadogTracingToolkit and does not contain _TraceInternalProxy. In this module, checkApiSurfaceChanges validates both apiSurface and <module>.api, so leaving only one file updated makes the API artifacts inconsistent and will fail API-surface checks until :features:dd-sdk-android-trace:apiDump is regenerated and committed.

Useful? React with 👍 / 👎.

Seems like it either fixed with the last push or was not the case.
@codex review again please

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review

Mark a draft as ready

Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov-commenter · 2026-04-09T13:02:32Z

Codecov Report

❌ Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.97%. Comparing base (6c84850) to head (52900bf).

Files with missing lines	Patch %	Lines
...kotlin/com/datadog/android/trace/DatadogTracing.kt	0.00%	1 Missing and 1 partial ⚠️
...android/trace/internal/DatadogPropagationHelper.kt	33.33%	2 Missing ⚠️
...otlin/com/datadog/android/okhttp/otel/OkHttpExt.kt	33.33%	2 Missing ⚠️
...adog/opentelemetry/trace/OtelExtractedContext.java	0.00%	1 Missing ⚠️
.../com/datadog/opentelemetry/trace/OtelSpanLink.java	0.00%	1 Missing ⚠️
...datadog/android/okhttp/trace/TracingInterceptor.kt	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3350      +/-   ##
===========================================
- Coverage    71.98%   71.97%   -0.01%     
===========================================
  Files          956      956              
  Lines        35287    35292       +5     
  Branches      5858     5858              
===========================================
  Hits         25400    25400              
- Misses        8275     8282       +7     
+ Partials      1612     1610       -2

Files with missing lines	Coverage Δ
...java/com/datadog/opentelemetry/trace/OtelSpan.java	`57.81% <100.00%> (ø)`
...m/datadog/opentelemetry/trace/OtelSpanContext.java	`54.17% <100.00%> (ø)`
.../android/trace/opentelemetry/OtelTracerProvider.kt	`84.44% <100.00%> (ø)`
...ndroid/trace/internal/ApmNetworkInstrumentation.kt	`60.98% <ø> (ø)`
...adog/android/trace/internal/_TraceInternalProxy.kt	`33.33% <ø> (ø)`
...trace/internal/net/ApmNetworkInstrumentationExt.kt	`69.23% <ø> (ø)`
.../datadog/android/cronet/CronetIntegrationPlugin.kt	`94.64% <100.00%> (ø)`
.../datadog/android/okhttp/OkHttpIntegrationPlugin.kt	`84.75% <100.00%> (ø)`
...adog/opentelemetry/trace/OtelExtractedContext.java	`0.00% <0.00%> (ø)`
.../com/datadog/opentelemetry/trace/OtelSpanLink.java	`0.00% <0.00%> (ø)`
... and 4 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

satween requested review from a team as code owners April 9, 2026 11:21

kikoveiga previously approved these changes Apr 9, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

satween dismissed kikoveiga’s stale review via 92a9d92 April 9, 2026 12:29

satween force-pushed the tvaleev/feature/RUM-15544- branch from 5e969c3 to 92a9d92 Compare April 9, 2026 12:29

This comment has been minimized.

Sign in to view

kikoveiga previously approved these changes Apr 9, 2026

View reviewed changes

0xnm previously approved these changes Apr 9, 2026

View reviewed changes

RUM-15544: DatadogTracingToolkit.kt -> _TraceInternalProxy

52900bf

satween dismissed stale reviews from 0xnm and kikoveiga via 52900bf April 16, 2026 12:07

satween force-pushed the tvaleev/feature/RUM-15544- branch from 92a9d92 to 52900bf Compare April 16, 2026 12:07

satween requested review from 0xnm and kikoveiga April 16, 2026 15:53

kikoveiga approved these changes Apr 16, 2026

View reviewed changes

satween merged commit e293f09 into develop Apr 16, 2026
27 checks passed

satween deleted the tvaleev/feature/RUM-15544- branch April 16, 2026 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RUM-15544: DatadogTracingToolkit.kt -> _TraceInternalProxy#3350

RUM-15544: DatadogTracingToolkit.kt -> _TraceInternalProxy#3350
satween merged 1 commit into
developfrom
tvaleev/feature/RUM-15544-

satween commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Uh oh!

satween Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Uh oh!

This comment has been minimized.

codecov-commenter commented Apr 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

satween commented Apr 9, 2026

What does this PR do?

Review checklist (to be filled by reviewers)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

satween Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

codecov-commenter commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Apr 9, 2026 •

edited

Loading