RUM-15423: Fix B3/B3multi propagation headers being silently dropped#3347
Merged
kikoveiga merged 2 commits intoApr 9, 2026
Merged
Conversation
kikoveiga
force-pushed
the
kikoveiga/RUM-15423/fix-datadog-tracer-property-names
branch
from
April 8, 2026 13:22
05e1c97 to
4823f88
Compare
kikoveiga
marked this pull request as ready for review
April 8, 2026 13:24
ambushwork
previously approved these changes
Apr 8, 2026
0xnm
previously approved these changes
Apr 8, 2026
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
It would be nice to add the test covering the issue.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3347 +/- ##
===========================================
- Coverage 71.52% 71.49% -0.03%
===========================================
Files 946 947 +1
Lines 34916 34919 +3
Branches 5920 5921 +1
===========================================
- Hits 24973 24963 -10
- Misses 8272 8283 +11
- Partials 1671 1673 +2
🚀 New features to boost your workflow:
|
Contributor
Author
Added, thank you! The test to inject B3 single header was failing, so managed to find the deeper issue related with dd-trace-java as explained in the PR description. |
kikoveiga
force-pushed
the
kikoveiga/RUM-15423/fix-datadog-tracer-property-names
branch
from
April 8, 2026 16:10
acf38d6 to
096e765
Compare
kikoveiga
force-pushed
the
kikoveiga/RUM-15423/fix-datadog-tracer-property-names
branch
from
April 8, 2026 16:12
096e765 to
243d09f
Compare
0xnm
approved these changes
Apr 9, 2026
kikoveiga
deleted the
kikoveiga/RUM-15423/fix-datadog-tracer-property-names
branch
April 9, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TRACE_PROPAGATION_STYLE_EXTRACT&TRACE_PROPAGATION_STYLE_INJECTproperties inDatadogTracingConstants.kt.PROPAGATION_STYLE_EXTRACT&PROPAGATION_STYLE_INJECTthat are now unused.B3type toB3SINGLEas expected indd-trace-javaTracePropagationStyle. Otherwise, it would be silently converted toB3MULTI.TracingHeaderTypeinTracingHeaderTypePropagationTest.kt.After some set up in
SampleApplication'sGlobalDatadogTracer,DatadogInterceptorandTracingInterceptor, and using these new constants, we can see the headers are now used and captured withtrackResourceHeaders:B3 (Single)
B3Multi
Motivation
RUM-15423:
DatadogTracerBuilderAdapterwas writing properties with keyspropagation.style.inject/extract, butConfig.javareadstrace.propagation.style.inject/extracthere, causing a mismatch and fallback to default Datadog + TraceContext.Review checklist (to be filled by reviewers)