Skip to content

Migrate ProcessLifecycleMonitor from core to internal#3345

Merged
ambushwork merged 1 commit into
developfrom
yl/migrate-process-lifecyle-monitor
Apr 8, 2026
Merged

Migrate ProcessLifecycleMonitor from core to internal#3345
ambushwork merged 1 commit into
developfrom
yl/migrate-process-lifecyle-monitor

Conversation

@ambushwork

@ambushwork ambushwork commented Apr 8, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Migrate ProcessLifecycleMonitor from dd-sdk-android-core to dd-sdk-android-internal so that it can be used by other modules while keeping it not public to users.

Motivation

Continuous Profiling needs to reuse this class to track the application lifecycle when it goes to the background or foreground.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/migrate-process-lifecyle-monitor branch 4 times, most recently from 62176d3 to facf5c0 Compare April 8, 2026 12:14
@ambushwork
ambushwork force-pushed the yl/migrate-process-lifecyle-monitor branch from facf5c0 to 8b0890b Compare April 8, 2026 12:43
@datadog-prod-us1-5

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.49%. Comparing base (1425287) to head (8b0890b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3345      +/-   ##
===========================================
- Coverage    71.51%   71.49%   -0.02%     
===========================================
  Files          946      946              
  Lines        34916    34916              
  Branches      5920     5920              
===========================================
- Hits         24968    24960       -8     
  Misses        8280     8280              
- Partials      1668     1676       +8     
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/DatadogCore.kt 77.66% <ø> (ø)
...in/com/datadog/android/core/internal/SdkFeature.kt 90.00% <ø> (ø)
...ore/internal/lifecycle/ProcessLifecycleCallback.kt 90.00% <ø> (ø)
...id/core/internal/metrics/BatchMetricsDispatcher.kt 94.59% <ø> (+1.35%) ⬆️
...roid/internal/lifecycle/ProcessLifecycleMonitor.kt 82.35% <100.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review April 8, 2026 13:21
@ambushwork
ambushwork requested review from a team as code owners April 8, 2026 13:22
@ambushwork
ambushwork merged commit 0f075dd into develop Apr 8, 2026
26 checks passed
@ambushwork
ambushwork deleted the yl/migrate-process-lifecyle-monitor branch April 8, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants