RUM-15454: Add Profiler status in RUM debug widget#3335
Merged
ambushwork merged 1 commit intoApr 3, 2026
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling/add-debug-widget-indicator
branch
from
April 3, 2026 13:19
12cceb8 to
db93569
Compare
ambushwork
marked this pull request as ready for review
April 3, 2026 13:20
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db935697f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0xnm
reviewed
Apr 3, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3335 +/- ##
=============================================================
Coverage 71.53% 71.53%
=============================================================
Files 948 948
Lines 35072 35092 +20
Branches 5945 5950 +5
=============================================================
+ Hits 25087 25103 +16
- Misses 8300 8312 +12
+ Partials 1685 1677 -8
🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/profiling/add-debug-widget-indicator
branch
2 times, most recently
from
April 3, 2026 14:08
4061876 to
4e9e635
Compare
0xnm
reviewed
Apr 3, 2026
| // Set the profiling flag in SharedPreferences to profile for the next app launch | ||
| ProfilingStorage.addProfilingFlag(appContext, sdkCore.name) | ||
| sdkCore.setEventReceiver(name, this) | ||
| // TODO RUM-13678: we need to update context from the actual profiler start call, not from here |
Member
There was a problem hiding this comment.
probably the comment still makes sense?
Member
Author
There was a problem hiding this comment.
This is outdated so I decide to remove it:
- the profiling status is already updated both in
ContinuousProfilingSchedulerwhen it starts, also updated when the callback is called as described in TODO - but an update is still needed here for app-launch profiling since the moment when app-launch profiling is started, no context is available for updating, so we need to fetch the profiler status once we initialize the Profiling feature (this is the earliest moment that we can).
| override fun onContextUpdate(featureName: String, context: Map<String, Any?>) { | ||
| if (featureName == Feature.PROFILING_FEATURE_NAME) { | ||
| val running = context[PROFILER_IS_RUNNING] as? Boolean ?: false | ||
| handler.post { |
Member
There was a problem hiding this comment.
seems like the common approach in this class is to call withListenersUpdate, but having more fine-grained approach doesn't hurt anyway
| } | ||
|
|
||
| override fun bindSdkCore(sdkCore: FeatureSdkCore) { | ||
| sdkCore.setContextUpdateReceiver(this) |
Member
There was a problem hiding this comment.
should we unsubscribe at some point?
Member
Author
There was a problem hiding this comment.
good point, fixed with new unbindSdkCore function
| internal const val ONE_SECOND_NS = 1_000_000_000L | ||
|
|
||
| // Contract key; must match ProfilingFeature.PROFILER_IS_RUNNING in dd-sdk-android-profiling. | ||
| private const val PROFILER_IS_RUNNING = "profiler_is_running" |
Member
There was a problem hiding this comment.
for the future: maybe we can move it to the -internal module to share though
Member
Author
There was a problem hiding this comment.
yes, I wanted to do that but it involves too many places, so I decided to address it in another PR.
ambushwork
force-pushed
the
yl/profiling/add-debug-widget-indicator
branch
from
April 3, 2026 14:49
4e9e635 to
91e00d2
Compare
0xnm
approved these changes
Apr 3, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
It's convenient for debugging continuous profiling
Demo
Review checklist (to be filled by reviewers)