Fix continuous profiling back-to-back with app launch by inserting a cooldown window#3334
Merged
ambushwork merged 1 commit intoApr 2, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
ambushwork
force-pushed
the
yl/profiling/fix-continuous-profiling-cycle
branch
from
April 2, 2026 14:27
a2ec138 to
6c27db8
Compare
ambushwork
marked this pull request as ready for review
April 2, 2026 15:02
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3334 +/- ##
================================================================
- Coverage 71.52% 71.48% -0.04%
================================================================
Files 948 948
Lines 35038 35039 +1
Branches 5937 5937
================================================================
- Hits 25060 25045 -15
- Misses 8313 8318 +5
- Partials 1665 1676 +11
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this PR the second active window of continuous profiling is launched immediately after app-launch profiling, which causes some back-to-back issue.
This PR fixes it by inserting a cooldown window after app launch profiling has completed as RFC described.
Review checklist (to be filled by reviewers)