RUM-15321: Continuous profiling writes are gated on pending RUM events#3310
Merged
ambushwork merged 1 commit intoApr 3, 2026
Conversation
ambushwork
force-pushed
the
yl/profiling/forward-rum-events-to-scheduler
branch
2 times, most recently
from
April 1, 2026 09:56
e56483e to
48af4ae
Compare
This comment has been minimized.
This comment has been minimized.
ambushwork
force-pushed
the
yl/profiling/forward-rum-events-to-scheduler
branch
from
April 1, 2026 10:42
48af4ae to
3b707c8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3310 +/- ##
================================================================
+ Coverage 71.50% 71.56% +0.06%
================================================================
Files 948 948
Lines 35039 35072 +33
Branches 5937 5945 +8
================================================================
+ Hits 25052 25096 +44
+ Misses 8313 8295 -18
- Partials 1674 1681 +7
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
April 1, 2026 11:20
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b707c8843
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kikoveiga
reviewed
Apr 1, 2026
ambushwork
force-pushed
the
yl/profiling/forward-rum-events-to-scheduler
branch
2 times, most recently
from
April 2, 2026 11:58
2067c2a to
0587586
Compare
kikoveiga
previously approved these changes
Apr 2, 2026
0xnm
reviewed
Apr 3, 2026
|
|
||
| override fun write( | ||
| profilingResult: PerfettoResult, | ||
| rumContext: ProfilingRumContext, |
Member
There was a problem hiding this comment.
I don't think it should be a single ProfilingRumContext, it should be the aggregation here.
Comment on lines
+380
to
+388
| testedFeature = ProfilingFeature( | ||
| mockSdkCore, | ||
| ProfilingConfiguration( | ||
| customEndpointUrl = null, | ||
| applicationLaunchSampleRate = 100f, | ||
| continuousSampleRate = 100f | ||
| ), | ||
| mockProfiler | ||
| ) |
Member
There was a problem hiding this comment.
shouldn't we pull this to the common setup method?
Member
Author
There was a problem hiding this comment.
testedFeature needs to be initialized with a full sample rate configuration in some tests, I added a fakeAllSampledConfiguration to reuse.
| return this | ||
| } | ||
|
|
||
| fun hasLongTaskIds(expected: List<String>?): ProfileEventAssert { |
Member
There was a problem hiding this comment.
seems it is not used anywhere so far? is it supposed to be used in this PR?
Member
Author
There was a problem hiding this comment.
it belongs to my next PR, it's a miss when splitting, removed.
Comment on lines
+369
to
+370
| assertThat(testedScheduler.pendingLongTasks).isEqualTo(listOf(fakeRumLongTaskEvent)) | ||
| assertThat(testedScheduler.pendingAnrEvents).isEqualTo(listOf(fakeRumAnrEvent)) |
Member
There was a problem hiding this comment.
tip: alternatively containsOnly can be used to avoid extra listOf call
Suggested change
| assertThat(testedScheduler.pendingLongTasks).isEqualTo(listOf(fakeRumLongTaskEvent)) | |
| assertThat(testedScheduler.pendingAnrEvents).isEqualTo(listOf(fakeRumAnrEvent)) | |
| assertThat(testedScheduler.pendingLongTasks).containsOnly(fakeRumLongTaskEvent) | |
| assertThat(testedScheduler.pendingAnrEvents).containsOnly(fakeRumAnrEvent) |
ambushwork
force-pushed
the
yl/profiling/forward-rum-events-to-scheduler
branch
from
April 3, 2026 09:39
0587586 to
590883f
Compare
0xnm
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Long task events and ANR Error events are forwarded to
ContinuousProfilingSchedulerwhen they are received byProfilingFeature. Before we try to write the events for continuous profiling, we check if there are pending RUM events, this respects the fact that continuous profiling result should only be uploaded when there are crucial RUM events during the profiling.Note:
ContinuousProfilingScheduleronly accepts the RUM events when the active window is open (profiler is running), otherwise the events will be dropped since they are not happening during the profiling window.Motivation
RUM-15321
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)