RUM-15334: Add id to RumAnrEvent and RumLongTaskEvent#3309
Merged
ambushwork merged 1 commit intoMar 31, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3309 +/- ##
================================================================
- Coverage 71.53% 71.49% -0.04%
================================================================
Files 948 948
Lines 35032 35038 +6
Branches 5937 5937
================================================================
- Hits 25058 25047 -11
- Misses 8298 8315 +17
Partials 1676 1676
🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/profiling/add-id-into-profiling-rum-event
branch
from
March 31, 2026 13:31
728ec87 to
19c032f
Compare
ambushwork
marked this pull request as ready for review
March 31, 2026 13:32
0xnm
approved these changes
Mar 31, 2026
kikoveiga
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
nit: rename to ProfilerEventRumAnrEventForgeryFactory for consistency.
Member
Author
There was a problem hiding this comment.
good point, I will fix it in the following PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RumAnrEventandRumLongTaskEventshould have unique id when sending them to ProfilingFeature.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)