Skip to content

RUM-15277: Propagate native anonymousId to webview events#3306

Merged
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events
Apr 16, 2026
Merged

RUM-15277: Propagate native anonymousId to webview events#3306
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Propagates the native anonymousId into webview RUM and Log events. Even if browser set it on their side, we will overwrite it (we do the same with applicationId, for instance).

iOS counterpart: DataDog/dd-sdk-ios#2847

Motivation

RUMS-5561

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch 3 times, most recently from 022dd69 to 14549c7 Compare March 30, 2026 15:36
@kikoveiga
kikoveiga requested a review from cdn34dd March 30, 2026 15:36
@kikoveiga
kikoveiga marked this pull request as ready for review March 30, 2026 15:44
@kikoveiga
kikoveiga requested review from a team as code owners March 30, 2026 15:44
0xnm
0xnm previously approved these changes Mar 30, 2026
View reviewed changes
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 30, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14549c7219

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ...-webview/src/main/kotlin/com/datadog/android/webview/internal/log/WebViewLogEventConsumer.kt Outdated
Comment thread ...id-webview/src/main/kotlin/com/datadog/android/webview/internal/rum/WebViewRumEventMapper.kt Outdated
@datadog-datadog-prod-us1-2

This comment has been minimized.

Sign in to view
@kikoveiga kikoveiga self-assigned this Mar 30, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch from 14549c7 to e09a136 Compare March 31, 2026 10:07
0xnm
0xnm previously approved these changes Mar 31, 2026
View reviewed changes
@codecov-commenter

codecov-commenter commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.84%. Comparing base (bc97e25) to head (496b91d).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
...roid/webview/internal/rum/WebViewRumEventMapper.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3306      +/-   ##
===========================================
- Coverage    71.86%   71.84%   -0.02%     
===========================================
  Files          947      947              
  Lines        34919    34933      +14     
  Branches      5801     5805       +4     
===========================================
+ Hits         25093    25097       +4     
- Misses        8232     8249      +17     
+ Partials      1594     1587       -7
Files with missing lines Coverage Δ
...id/webview/internal/log/WebViewLogEventConsumer.kt 82.29% <100.00%> (+0.97%) ⬆️
...id/webview/internal/rum/WebViewRumEventConsumer.kt 92.06% <100.00%> (+0.68%) ⬆️
...roid/webview/internal/rum/WebViewRumEventMapper.kt 97.14% <80.00%> (-2.86%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga changed the title Propagate user info to webview events Merge native user info to webview events Mar 31, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch 3 times, most recently from b9f52a4 to de7985d Compare March 31, 2026 11:59
ambushwork
ambushwork previously approved these changes Apr 1, 2026
View reviewed changes
Comment thread ...-webview/src/main/kotlin/com/datadog/android/webview/internal/log/WebViewLogEventConsumer.kt Outdated
@kikoveiga kikoveiga changed the title Merge native user info to webview events RUM-15277: Merge native user info to webview events Apr 1, 2026
@mariusc83 mariusc83 closed this Apr 2, 2026
cdn34dd

This comment was marked as resolved.

Sign in to view

@kikoveiga kikoveiga reopened this Apr 2, 2026
@kikoveiga kikoveiga changed the title RUM-15277: Merge native user info to webview events RUM-15277: Propagate native anonymousId to webview events Apr 13, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch 2 times, most recently from 443ed1c to 447d46a Compare April 13, 2026 15:31
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch from 447d46a to 633545f Compare April 13, 2026 15:42
@kikoveiga
kikoveiga requested review from 0xnm and cdn34dd April 13, 2026 15:46
0xnm
0xnm previously approved these changes Apr 14, 2026
View reviewed changes
@kikoveiga kikoveiga mentioned this pull request Apr 15, 2026
Merged
5 tasks
This was referenced Apr 15, 2026
Open
Open
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch from 633545f to 8624ffb Compare April 16, 2026 09:39
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch from 8624ffb to 496b91d Compare April 16, 2026 11:56
@allspain allspain mentioned this pull request Apr 16, 2026
Open
5 tasks
@kikoveiga
kikoveiga requested a review from 0xnm April 16, 2026 12:53
@kikoveiga
kikoveiga merged commit fc14d5b into develop Apr 16, 2026
27 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/RUM-15277/propagate-anonymous-user-id-to-webview-events branch April 16, 2026 13:02
This was referenced Apr 16, 2026
Open
Open
Open
@kikoveiga
kikoveiga removed the request for review from cdn34dd April 17, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork left review comments
@cdn34dd cdn34dd cdn34dd left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@0xnm 0xnm 0xnm approved these changes

Assignees

@kikoveiga kikoveiga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kikoveiga @codecov-commenter @0xnm @ambushwork @cdn34dd @mariusc83