RUM-15307: Report failure through ProfilerCallback#3305
Merged
ambushwork merged 1 commit intoMar 31, 2026
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling/add-on-failure-callback
branch
from
March 30, 2026 14:52
8f2dec5 to
f779a95
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3305 +/- ##
================================================================
- Coverage 71.52% 71.50% -0.02%
================================================================
Files 947 947
Lines 34967 34976 +9
Branches 5924 5927 +3
================================================================
Hits 25009 25009
- Misses 8283 8298 +15
+ Partials 1675 1669 -6
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
March 30, 2026 14:54
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f779a95920
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
0xnm
previously approved these changes
Mar 31, 2026
ambushwork
force-pushed
the
yl/profiling/add-on-failure-callback
branch
from
March 31, 2026 07:27
f779a95 to
2b44b3b
Compare
0xnm
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
onFaliure()intoProfilerCallbackso that any failure of app launch profiling is reported toContinuousProfilingScheduler, in order to notify it the app launch profiling has completed.Motivation
RUM-15307
Review checklist (to be filled by reviewers)