RUM-1061: Don't send rum context when sessionId is NULL_UUID#3304
Conversation
kikoveiga
changed the title
ef91d66 to
4317378
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43173787c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7c62ccf | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3304 +/- ##
===========================================
- Coverage 71.49% 71.43% -0.07%
===========================================
Files 946 946
Lines 34895 34895
Branches 5906 5908 +2
===========================================
- Hits 24947 24924 -23
- Misses 8283 8289 +6
- Partials 1665 1682 +17
🚀 New features to boost your workflow:
|
| val rumContext = currentRumContext() | ||
| sdkCore.updateFeatureContext(Feature.RUM_FEATURE_NAME) { | ||
| it.putAll(currentFeatureContext.toMap()) | ||
| it.clear() |
There was a problem hiding this comment.
Calling clear is not quite correct if RUM feature context has something on top of the RumContext. Is it needed?
There was a problem hiding this comment.
In this class are the only places where we call updateFeatureContext with Feature.RUM_FEATURE_NAME, so the idea was to clear stale entries, should I still remove it?
7e1446a to
7c62ccf
Compare
5 participants
What does this PR do?
null RumContextwhenactiveSessionisnull.NULL_UUIDRUM session ids from being published to the shared feature context. The context is now also cleared of any stale values from a previous session.Review checklist (to be filled by reviewers)