Skip to content

Send event to Profiling feature when RUM session is renewed#3297

Merged
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/send-rum-sampling-event-to-profiling
Mar 25, 2026
Merged

Send event to Profiling feature when RUM session is renewed#3297
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/send-rum-sampling-event-to-profiling

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

This PR implements the logic that RUM should send event to Profiling feature when RUM session is renewed before continuous profiling is implemented.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ambushwork
ambushwork marked this pull request as ready for review March 25, 2026 14:00
@ambushwork
ambushwork requested review from a team as code owners March 25, 2026 14:00
@codecov-commenter

codecov-commenter commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (8cbed9b) to head (9f91148).

Files with missing lines Patch % Lines
...dog/android/internal/rum/RumSessionRenewedEvent.kt 0.00% 3 Missing ⚠️
...dog/android/profiling/internal/ProfilingFeature.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/continuous-profiling    #3297      +/-   ##
================================================================
+ Coverage                         71.42%   71.52%   +0.10%     
================================================================
  Files                               943      944       +1     
  Lines                             34862    34873      +11     
  Branches                           5909     5912       +3     
================================================================
+ Hits                              24900    24941      +41     
+ Misses                             8297     8271      -26     
+ Partials                           1665     1661       -4     
Files with missing lines Coverage Δ
...droid/rum/internal/domain/scope/RumSessionScope.kt 91.30% <100.00%> (+0.34%) ⬆️
...dog/android/profiling/internal/ProfilingFeature.kt 66.07% <75.00%> (-0.60%) ⬇️
...dog/android/internal/rum/RumSessionRenewedEvent.kt 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork force-pushed the yl/profiling/send-rum-sampling-event-to-profiling branch from e09a59f to 41374ff Compare March 25, 2026 14:13
kikoveiga
kikoveiga previously approved these changes Mar 25, 2026
@ambushwork
ambushwork force-pushed the yl/profiling/send-rum-sampling-event-to-profiling branch from 41374ff to 0dc309e Compare March 25, 2026 14:54
@ambushwork
ambushwork force-pushed the yl/profiling/send-rum-sampling-event-to-profiling branch from 0dc309e to 9f91148 Compare March 25, 2026 15:12
@ambushwork

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-official

This comment has been minimized.

@ambushwork
ambushwork merged commit f5e2767 into feature/continuous-profiling Mar 25, 2026
26 checks passed
@ambushwork
ambushwork deleted the yl/profiling/send-rum-sampling-event-to-profiling branch March 25, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants