Skip to content

RUM-14896: Make flush accessible from InternalProxy#3292

Merged
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/RUM-14896/flush-internal-proxy
Mar 25, 2026
Merged

RUM-14896: Make flush accessible from InternalProxy#3292
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/RUM-14896/flush-internal-proxy

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

We plan to use flush in our new integration testing framework.

Similar PR in iOS DataDog/dd-sdk-ios#2757

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.59%. Comparing base (b94905c) to head (b33baba).
⚠️ Report is 122 commits behind head on develop.

Files with missing lines Patch % Lines
.../main/kotlin/com/datadog/android/_InternalProxy.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3292      +/-   ##
===========================================
+ Coverage    71.39%   71.59%   +0.19%     
===========================================
  Files          940      940              
  Lines        34764    34769       +5     
  Branches      5894     5895       +1     
===========================================
+ Hits         24819    24890      +71     
+ Misses        8294     8251      -43     
+ Partials      1651     1628      -23     
Files with missing lines Coverage Δ
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 71.74% <ø> (ø)
.../main/kotlin/com/datadog/android/_InternalProxy.kt 62.50% <0.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b33baba93a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review March 25, 2026 12:17
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners March 25, 2026 12:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b33baba93a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aleksandr-gringauz
aleksandr-gringauz merged commit e37f350 into develop Mar 25, 2026
27 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/RUM-14896/flush-internal-proxy branch March 25, 2026 12:19
@ncreated
ncreated restored the aleksandr-gringauz/RUM-14896/flush-internal-proxy branch April 9, 2026 09:49
@0xnm
0xnm deleted the aleksandr-gringauz/RUM-14896/flush-internal-proxy branch April 24, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants