Update profiling telemetry duration, add callback delay data#3284
Conversation
ae3c10d to
644875b
Compare
This comment has been minimized.
This comment has been minimized.
644875b to
e4d8818
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4d881866b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e4d8818 to
6ae5050
Compare
6ae5050 to
d9def31
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9def31688
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3284 +/- ##
===========================================
- Coverage 71.63% 71.47% -0.16%
===========================================
Files 943 943
Lines 34815 34820 +5
Branches 5899 5899
===========================================
- Hits 24937 24886 -51
- Misses 8244 8273 +29
- Partials 1634 1661 +27
🚀 New features to boost your workflow:
|
3 participants
What does this PR do?
Currently the duration in profiling telemetry data measures the duration from the time when
PerfettoProfiler.starttoProfilingMangaercallback is called, this is composed by 3 parts:In this case the duration data in telemetry is always bigger than the profile duration that we measure in the backend. To be closer to the effective profiling duration, This PR removes the third part - "Delay for the result post-processing" by mark the end time once
PerfettoProfiler.stopis called, (it is still not the accurate effective profiling duration since it still contains the delay of starting and introduce the negative delay of stopping the profiler though). The callback time is still preserved so that we can have data about how much the delay that post-processing introduces.Review checklist (to be filled by reviewers)