Skip to content

RUM-11445: Fix detekt InvalidStringFormat false alarms#3278

Merged
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-11445/invalid-string-format
Mar 23, 2026
Merged

RUM-11445: Fix detekt InvalidStringFormat false alarms#3278
kikoveiga merged 2 commits into
developfrom
kikoveiga/RUM-11445/invalid-string-format

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fix InvalidStringFormat false positives by adding transitive module dependencies to the custom detekt rule's classpath.
  • Add PackageQualifier handling in ReceiverExt to eliminate Unknown receiver type warnings.
  • Fix local_ci.sh early exit.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga self-assigned this Mar 20, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-11445/invalid-string-format branch from 8ba4402 to 9d26d15 Compare March 20, 2026 17:09
@datadog-prod-us1-6

This comment has been minimized.

Sign in to view
@codecov-commenter

codecov-commenter commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (3299104) to head (abf235f).

Files with missing lines Patch % Lines
...android/trace/internal/DatadogPropagationHelper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3278      +/-   ##
===========================================
+ Coverage    71.44%   71.46%   +0.03%     
===========================================
  Files          942      942              
  Lines        34812    34812              
  Branches      5900     5900              
===========================================
+ Hits         24868    24878      +10     
+ Misses        8288     8275      -13     
- Partials      1656     1659       +3
Files with missing lines Coverage Δ
...datadog/android/okhttp/trace/TracingInterceptor.kt 81.67% <ø> (-0.28%) ⬇️
...android/trace/internal/DatadogPropagationHelper.kt 66.46% <0.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga
kikoveiga marked this pull request as ready for review March 20, 2026 18:30
@kikoveiga
kikoveiga requested review from a team as code owners March 20, 2026 18:30
0xnm
0xnm previously approved these changes Mar 23, 2026
View reviewed changes
Comment thread ...android-trace/src/main/kotlin/com/datadog/android/trace/internal/DatadogPropagationHelper.kt
@kikoveiga
kikoveiga requested a review from 0xnm March 23, 2026 12:43
0xnm
0xnm previously approved these changes Mar 23, 2026
View reviewed changes
Comment thread tools/detekt/src/test/kotlin/com/datadog/tools/detekt/rules/sdk/InvalidStringFormatTest.kt Outdated
Comment thread tools/detekt/src/test/kotlin/com/datadog/tools/detekt/rules/sdk/InvalidStringFormatTest.kt Outdated
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-11445/invalid-string-format branch from a93f144 to 72d9975 Compare March 23, 2026 13:25
@kikoveiga
kikoveiga force-pushed the kikoveiga/RUM-11445/invalid-string-format branch from 72d9975 to abf235f Compare March 23, 2026 13:26
@kikoveiga
kikoveiga requested a review from 0xnm March 23, 2026 13:26
@kikoveiga
kikoveiga merged commit 288b8df into develop Mar 23, 2026
26 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/RUM-11445/invalid-string-format branch March 23, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@kikoveiga kikoveiga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kikoveiga @codecov-commenter @0xnm