RUM-15190: Extend app launch profiling duration for continuous merge#3277
Merged
ambushwork merged 1 commit intoMar 25, 2026
Conversation
ambushwork
force-pushed
the
yl/profiling/RUM-15190-extend-launch-duration
branch
2 times, most recently
from
March 20, 2026 16:24
852ee36 to
0c9ffdc
Compare
ambushwork
marked this pull request as ready for review
March 20, 2026 16:50
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c9ffdc8fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ambushwork
force-pushed
the
yl/profiling/RUM-15190-extend-launch-duration
branch
2 times, most recently
from
March 23, 2026 10:46
b723e07 to
ca99587
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/continuous-profiling #3277 +/- ##
=============================================================
Coverage 71.50% 71.51%
=============================================================
Files 943 943
Lines 34844 34862 +18
Branches 5903 5909 +6
=============================================================
+ Hits 24915 24929 +14
- Misses 8269 8272 +3
- Partials 1660 1661 +1
🚀 New features to boost your workflow:
|
0xnm
reviewed
Mar 24, 2026
ambushwork
force-pushed
the
yl/profiling/RUM-15190-extend-launch-duration
branch
2 times, most recently
from
March 24, 2026 11:42
5c22cd3 to
8755c5d
Compare
0xnm
requested changes
Mar 25, 2026
ambushwork
force-pushed
the
yl/profiling/RUM-15190-extend-launch-duration
branch
from
March 25, 2026 08:41
8755c5d to
5adc26d
Compare
0xnm
previously approved these changes
Mar 25, 2026
ambushwork
force-pushed
the
yl/profiling/RUM-15190-extend-launch-duration
branch
from
March 25, 2026 12:35
5adc26d to
ed10d4b
Compare
0xnm
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the max duration of app launch profiling request from 10s -> (ttid, 1 min] in order to be able to extend as the continuous profiling, at the same time a timer of 10s is introduced to prevent the application launch profiling to go beyond 10 seconds if continuous profiling is not sampled in.
Motivation
RUM-15190
Review checklist (to be filled by reviewers)