Skip to content

RUM-15164: Use schema defined in rum-events-format to generate ProfileEvent#3268

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15164/use-main-profiling-schema-to-generate-event
Mar 18, 2026
Merged

RUM-15164: Use schema defined in rum-events-format to generate ProfileEvent#3268
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-15164/use-main-profiling-schema-to-generate-event

Conversation

@0xnm

@0xnm 0xnm commented Mar 18, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Switch to schema defined in https://github.com/DataDog/rum-events-format/tree/master/schemas/profiling instead of using hand-written one.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners March 18, 2026 09:46
ambushwork
ambushwork previously approved these changes Mar 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 384922757d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kikoveiga
kikoveiga previously approved these changes Mar 18, 2026
@datadog-official

This comment has been minimized.

@0xnm
0xnm dismissed stale reviews from kikoveiga and ambushwork via 16ee315 March 18, 2026 10:15
@0xnm
0xnm force-pushed the nogorodnikov/rum-15164/use-main-profiling-schema-to-generate-event branch from 3849227 to 16ee315 Compare March 18, 2026 10:15
@0xnm
0xnm requested review from ambushwork and kikoveiga March 18, 2026 10:15
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.45%. Comparing base (d57bbd8) to head (16ee315).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/profiling/internal/ProfilingDataWriter.kt 66.67% 2 Missing ⚠️
...og/android/internal/profiling/ProfilerStopEvent.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3268   +/-   ##
========================================
  Coverage    71.44%   71.45%           
========================================
  Files          941      941           
  Lines        34781    34785    +4     
  Branches      5896     5897    +1     
========================================
+ Hits         24849    24853    +4     
- Misses        8279     8281    +2     
+ Partials      1653     1651    -2     
Files with missing lines Coverage Δ
.../internal/startup/RumSessionScopeStartupManager.kt 96.61% <100.00%> (+0.03%) ⬆️
...og/android/internal/profiling/ProfilerStopEvent.kt 0.00% <0.00%> (ø)
.../android/profiling/internal/ProfilingDataWriter.kt 89.09% <66.67%> (+1.79%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit a23eeae into develop Mar 18, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-15164/use-main-profiling-schema-to-generate-event branch March 18, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants