Skip to content

RUM-15154: fix spans duplications#3267

Merged
satween merged 1 commit into
developfrom
tvaleev/feature/RUM-15154
Mar 18, 2026
Merged

RUM-15154: fix spans duplications#3267
satween merged 1 commit into
developfrom
tvaleev/feature/RUM-15154

Conversation

@satween

@satween satween commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix: Distributing tracing logic (APM <> RUM) will not send spans to the intake.
APM will send if allowed.

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners March 17, 2026 17:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f93e2e550f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-prod-us1-3

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.53%. Comparing base (d57bbd8) to head (f93e2e5).
⚠️ Report is 85 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3267      +/-   ##
===========================================
+ Coverage    71.44%   71.53%   +0.09%     
===========================================
  Files          941      941              
  Lines        34781    34793      +12     
  Branches      5896     5897       +1     
===========================================
+ Hits         24849    24888      +39     
  Misses        8279     8279              
+ Partials      1653     1626      -27     
Files with missing lines Coverage Δ
.../datadog/android/cronet/CronetIntegrationPlugin.kt 98.21% <100.00%> (+3.67%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween

satween commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 18, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-18 10:11:05 UTC ℹ️ Start processing command /merge


2026-03-18 10:11:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).


2026-03-18 10:30:06 UTC ℹ️ MergeQueue: Retrying because an high priority merge request needed to be processed first. No action is needed from your side.


2026-03-18 10:30:09 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@satween
satween merged commit 1fbe367 into develop Mar 18, 2026
27 of 28 checks passed
@satween
satween deleted the tvaleev/feature/RUM-15154 branch March 18, 2026 10:30
@ncreated
ncreated restored the tvaleev/feature/RUM-15154 branch April 9, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants