RUM-15146: Downgrading androidx-core to 1.15.0 in order to preserve android 35 compile sdk compatibility#3266
Conversation
…ndroid 35 compile sdk compatibility
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f6b049558
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| androidXComposeRuntime = "1.5.14" | ||
| androidXConstraintLayout = "2.0.4" | ||
| androidXCore = "1.17.0" | ||
| androidXCore = "1.15.0" |
There was a problem hiding this comment.
Changing androidXCore here updates dependency resolution for many modules, but the checked-in transitiveDependencies manifests were not updated (for example, features/dd-sdk-android-rum/transitiveDependencies still records androidx.core 1.17.0). I inspected build.gradle.kts and buildSrc/src/main/kotlin/com/datadog/gradle/plugin/transdeps/CheckTransitiveDependenciesTask.kt, and those checks verify generated files against git state; with this catalog change alone, running checkTransitiveDependenciesList/checkGeneratedFiles will report drift until the manifests are regenerated and committed.
Useful? React with 👍 / 👎.
…ndroid 35 compile sdk compatibility
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3266 +/- ##
===========================================
+ Coverage 71.35% 71.50% +0.14%
===========================================
Files 940 940
Lines 34774 34785 +11
Branches 5894 5895 +1
===========================================
+ Hits 24812 24870 +58
+ Misses 8310 8284 -26
+ Partials 1652 1631 -21 🚀 New features to boost your workflow:
|
4 participants
What does this PR do?
Downgrades
androidx-coreto1.15.0in order to preserve android 35 compile sdk compatibilityMotivation
RUM depends on
androidx-coreso we cannot increase it's version without increasingcompileSdkon a client side.Review checklist (to be filled by reviewers)