Avoid logging test assumptions failures to stderr#3263
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 489e14b0f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0xnm
force-pushed
the
nogorodnikov/avoid-logging-failed-test-assumptions
branch
from
March 16, 2026 11:35
489e14b to
ad79314
Compare
satween
previously approved these changes
Mar 16, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3263 +/- ##
===========================================
- Coverage 71.45% 71.36% -0.09%
===========================================
Files 940 940
Lines 34774 34774
Branches 5894 5894
===========================================
- Hits 24846 24816 -30
- Misses 8295 8308 +13
- Partials 1633 1650 +17 🚀 New features to boost your workflow:
|
hamorillo
previously approved these changes
Mar 16, 2026
0xnm
force-pushed
the
nogorodnikov/avoid-logging-failed-test-assumptions
branch
from
March 16, 2026 15:01
ad79314 to
1d72724
Compare
hamorillo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A quality of life improvement: if test assumption fails, it logs to the stderr and it can bring some confusion by thinking that test failed (it was skipped instead).
In this PR we tweak test logging to log to stderr only if test failed instead.
Review checklist (to be filled by reviewers)