Relax offset for floating point numbers assertions#3262
Merged
0xnm merged 1 commit intoMar 16, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
kikoveiga
approved these changes
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3262 +/- ##
===========================================
- Coverage 71.45% 71.41% -0.04%
===========================================
Files 940 940
Lines 34774 34774
Branches 5894 5894
===========================================
- Hits 24846 24831 -15
- Misses 8295 8302 +7
- Partials 1633 1641 +8 🚀 New features to boost your workflow:
|
0xnm
deleted the
nogorodnikov/relax-offset-for-floating-point-assertions
branch
March 16, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up for #3247.
We have now more floating pointing properties to assert and current offset makes tests fail in 50% of cases. Relaxing it a bit to have less failures (I didn't have any over 100 test runs).
It is expected to have a difference between number in the original objects vs number in the deserialized one:
Review checklist (to be filled by reviewers)