RUM-15081: Fix memory corruption in NDK module#3257
Merged
Conversation
kikoveiga
approved these changes
Mar 13, 2026
ambushwork
approved these changes
Mar 13, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3257 +/- ##
===========================================
- Coverage 71.37% 71.35% -0.03%
===========================================
Files 940 940
Lines 34773 34773
Branches 5894 5894
===========================================
- Hits 24819 24810 -9
- Misses 8304 8313 +9
Partials 1650 1650 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backtrace copy logic in NDK can corrupt memory by accessing the address outside of boundary in case if
str.size()is bigger thanmax_sizewe reserved.This PR puts the termination char at the correct position.
Review checklist (to be filled by reviewers)