Remove :tools:benchmark module from sample app dependencies#3253
Merged
Conversation
kikoveiga
approved these changes
Mar 12, 2026
This comment has been minimized.
This comment has been minimized.
hamorillo
approved these changes
Mar 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3253 +/- ##
===========================================
+ Coverage 71.35% 71.44% +0.09%
===========================================
Files 940 940
Lines 34764 34764
Branches 5893 5893
===========================================
+ Hits 24805 24835 +30
+ Misses 8312 8278 -34
- Partials 1647 1651 +4 🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is not used by the sample app but having it as a dependency declared triggers redundant compilation.
Review checklist (to be filled by reviewers)