RUM-13454: Add TODO for getResourceName inconsistency#3252
Merged
mariusc83 merged 1 commit intoMar 13, 2026
Conversation
Add JIRA ticket reference and PR link to the existing TODO comment for the getResourceName/hasResourceName inconsistency, deferring the fix to the next major release per team review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
mariusc83
marked this pull request as ready for review
March 12, 2026 08:41
hamorillo
approved these changes
Mar 12, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3252 +/- ##
===========================================
+ Coverage 71.35% 71.40% +0.05%
===========================================
Files 940 940
Lines 34764 34764
Branches 5893 5893
===========================================
+ Hits 24805 24821 +16
+ Misses 8312 8297 -15
+ Partials 1647 1646 -1
🚀 New features to boost your workflow:
|
satween
self-requested a review
March 12, 2026 11:43
satween
approved these changes
Mar 12, 2026
satween
left a comment
satween
left a comment
Contributor
There was a problem hiding this comment.
Thanks for highlighting this 👍
mariusc83
deleted the
mconstantin/RUM-13454/todo-resource-name-inconsistency
branch
March 13, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getResourceName()getResourceName/hasResourceNameinconsistency fix to the next major release, per team review feedback on Fix #2374: Make getResourceName() consistent with hasResourceName() #3244Context
PR #3244 attempted to fix the inconsistency between
getResourceName()andhasResourceName()but reviewers flagged that changing behavior in a minor release could skew existing dashboards/monitors. The team agreed to defer this to the next major release.Test plan
🤖 Generated with Claude Code