Skip to content

Update Proguard rules for GlobalDatadogTracer#3251

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/update-proguard-rules-for-globaldatadogtracer
Mar 12, 2026
Merged

Update Proguard rules for GlobalDatadogTracer#3251
0xnm merged 1 commit into
developfrom
nogorodnikov/update-proguard-rules-for-globaldatadogtracer

Conversation

@0xnm

@0xnm 0xnm commented Mar 11, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes the following exception:

java.lang.NoSuchMethodException: com.datadog.android.trace.GlobalDatadogTracer.getOrNull []

GlobalDatadogTracer class exists in the runtime classpath, but there is an error invoking isRegistered method

It is because of the keepnames usage, which a shorthand for -keep, allowshrinking: it will keep the name, but the method can still be shrinked. Switching to -keep, which won't allow method removal.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners March 11, 2026 16:20
@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.38%. Comparing base (002ba9f) to head (7b27e20).
⚠️ Report is 57 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3251   +/-   ##
========================================
  Coverage    71.37%   71.38%           
========================================
  Files          940      940           
  Lines        34764    34764           
  Branches      5893     5893           
========================================
+ Hits         24812    24813    +1     
- Misses        8298     8304    +6     
+ Partials      1654     1647    -7     
Files with missing lines Coverage Δ
...ndroid/telemetry/internal/TelemetryEventHandler.kt 88.53% <ø> (+2.35%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit ca51af4 into develop Mar 12, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/update-proguard-rules-for-globaldatadogtracer branch March 12, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants