RUM-2015: Remove PII from WebView event error logging#3250
Merged
Conversation
hamorillo
force-pushed
the
hector.morilloprieto/RUM-2015
branch
from
March 11, 2026 15:12
fc60c47 to
40160a3
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3250 +/- ##
===========================================
- Coverage 71.49% 71.46% -0.03%
===========================================
Files 938 938
Lines 34667 34667
Branches 5874 5874
===========================================
- Hits 24782 24773 -9
+ Misses 8247 8246 -1
- Partials 1638 1648 +10
🚀 New features to boost your workflow:
|
hamorillo
marked this pull request as ready for review
March 12, 2026 07:39
0xnm
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
MixedWebViewEventConsumer, three error log paths previously logged the full raw WebView event string — which could contain PII (log messages, resource URLs, user data, Session Replay content). This PR replaces the full event content with safe alternatives: the top-level key names for structural errors, and the event character count for JSON parse failures.Motivation
The full event string was sent to both logcat and Datadog internal telemetry targets, risking exposure of user-generated content. This change ensures PII is not leaked through error logging in the WebView tracking module.
Additional Notes
MixedWebViewEventConsumer.ktis modified in production code — the other WebView consumers (WebViewRumEventConsumer,WebViewLogEventConsumer,WebViewReplayEventConsumer) already log only static strings with no event content.Review checklist (to be filled by reviewers)