RUM-508: Exempt telemetry configuration event from the session event count limit#3248
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39e096fe04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
satween
force-pushed
the
tvaleev/feature/RUM-558
branch
2 times, most recently
from
March 11, 2026 12:11
f0d969d to
3d52f7f
Compare
0xnm
reviewed
Mar 11, 2026
satween
force-pushed
the
tvaleev/feature/RUM-558
branch
from
March 11, 2026 14:05
3d52f7f to
92baab6
Compare
0xnm
previously approved these changes
Mar 11, 2026
satween
force-pushed
the
tvaleev/feature/RUM-558
branch
from
March 11, 2026 14:40
92baab6 to
b1d1eef
Compare
0xnm
approved these changes
Mar 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3248 +/- ##
===========================================
+ Coverage 71.29% 71.33% +0.03%
===========================================
Files 938 938
Lines 34667 34667
Branches 5874 5875 +1
===========================================
+ Hits 24715 24727 +12
+ Misses 8305 8289 -16
- Partials 1647 1651 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exempt
InternalTelemetryEvent.Configurationevent from session limit (100 events per session).Motivation
InternalTelemetryEvent.Configurationis sent with 5 seconds delay, which (in theory) could lead to missing configuration events SDK already send 100 events to the moment whenInternalTelemetryEvent.Configurationwill be processed byTelemetryEventHandlerAdditional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)