fix: Only exclude files inside the repo#3246
Merged
Merged
Conversation
Fix an issue where GenerateCompilerMetaTask was ignoring all files in the repo if the path contained "test" anywhere in the path. Instead, make the path relative before checking if "test" is in the path. This is to fix an issue where the integration test library wants to include the SDK as a submodule / composite build.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3246 +/- ##
===========================================
- Coverage 71.37% 71.34% -0.04%
===========================================
Files 938 938
Lines 34667 34648 -19
Branches 5874 5872 -2
===========================================
- Hits 24743 24717 -26
- Misses 8278 8280 +2
- Partials 1646 1651 +5 🚀 New features to boost your workflow:
|
0xnm
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an issue where GenerateCompilerMetaTask was ignoring all files in the repo if the path contained "test" anywhere in the path. Instead, make the path relative before checking if "test" is in the path.
Motivation
This is to fix an issue where the integration test library wants to include the SDK as a submodule / composite build.
Review checklist (to be filled by reviewers)