Skip to content

use variant key instead of value in RUM feature flag tracking#3245

Merged
petzel merged 1 commit into
developfrom
eric.petzel/rum-ff-tracking-variant-key
Mar 10, 2026
Merged

use variant key instead of value in RUM feature flag tracking#3245
petzel merged 1 commit into
developfrom
eric.petzel/rum-ff-tracking-variant-key

Conversation

@petzel

@petzel petzel commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Copy of #3216 from non-fork due to CI limitations.

@petzel
petzel requested review from a team as code owners March 9, 2026 18:58
@petzel
petzel requested a review from yugisu-flux March 9, 2026 19:05
@datadog-datadog-prod-us1

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.43%. Comparing base (d46334a) to head (2e3a99b).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...tadog/android/flags/internal/DatadogFlagsClient.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3245      +/-   ##
===========================================
- Coverage    71.49%   71.43%   -0.06%     
===========================================
  Files          938      938              
  Lines        34667    34648      -19     
  Branches      5874     5872       -2     
===========================================
- Hits         24782    24748      -34     
- Misses        8247     8259      +12     
- Partials      1638     1641       +3     
Files with missing lines Coverage Δ
...tadog/android/flags/internal/DatadogFlagsClient.kt 90.00% <75.00%> (-2.59%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gh-worker-ownership-write-b05516
gh-worker-ownership-write-b05516 Bot removed the request for review from yugisu-flux March 10, 2026 08:31
@petzel
petzel merged commit a2a4a9a into develop Mar 10, 2026
27 checks passed
@petzel
petzel deleted the eric.petzel/rum-ff-tracking-variant-key branch March 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants