RUM-14903: Add basic AI dev tooling#3243
Conversation
6aae9b9 to
df939aa
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3243 +/- ##
========================================
Coverage 71.40% 71.40%
========================================
Files 938 938
Lines 34667 34667
Branches 5874 5874
========================================
Hits 24752 24752
- Misses 8265 8277 +12
+ Partials 1650 1638 -12 🚀 New features to boost your workflow:
|
df939aa to
8982b65
Compare
8982b65 to
b3da09a
Compare
| "Bash(ls:*)", | ||
| "Bash(find:*)", | ||
| "Bash(rg:*)", | ||
| "Bash(xargs rg:*)", | ||
| "Bash(grep:*)", | ||
| "Bash(sed:*)", | ||
| "Bash(awk:*)", | ||
| "Bash(cat:*)", | ||
| "Bash(git fetch:*)", | ||
| "Bash(git status:*)", | ||
| "Bash(git log:*)", | ||
| "Bash(git diff:*)", | ||
| "Bash(git show:*)", |
There was a problem hiding this comment.
These commands don't do anything dangerous, most of them just read things, so I think it is safe to allow Claude to execute them without explicitly asking for permission.
| "Bash(ktlint:*)", | ||
| "Bash(./gradlew *)" |
There was a problem hiding this comment.
These are android specific commands that are used to build code.
There was a problem hiding this comment.
I would say this one is less safer than others:
- it can be against what you commented above - it can write, modify and delete stuff such as compiling, cleaning ,etc.. (which is ok-ish though)
- it basically allows all kinds of gradle task that we don't know if they are safe or not.
There was a problem hiding this comment.
Yes, you are correct. I should have been more explicit about it. Executing a random gradle command can definitely delete and edit things. In my comment I was referring to the Bash commands.
However I still think that including ./gradlew here is fine in the context of Android SDK development.
| { | ||
| "$schema": "https://json.schemastore.org/claude-code-settings.json", | ||
| "permissions": { | ||
| "allow": [ |
There was a problem hiding this comment.
I decided not to include:
- Any permissions related to writing.
- Permissions from datadog mcp and mobile mcp.
Datadog MCP for example has some tools that change things. Some people might want to better control what tools Claude executes and explicitly grant permissions.
We can change it at any time.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3da09aacf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Bash(ktlint:*)", | ||
| "Bash(./gradlew *)" |
There was a problem hiding this comment.
I would say this one is less safer than others:
- it can be against what you commented above - it can write, modify and delete stuff such as compiling, cleaning ,etc.. (which is ok-ish though)
- it basically allows all kinds of gradle task that we don't know if they are safe or not.
hamorillo
left a comment
hamorillo
left a comment
There was a problem hiding this comment.
🚀 LGTM! Left some minor question/suggestion.
mariusc83
left a comment
mariusc83
left a comment
There was a problem hiding this comment.
Nice PR, could we have something also in there about how to run the end-to-end tests and the integration tests ?
f6112a4
done. But only for integration tests. E2E are run on synthetics. |
5 participants
Adding some basic files for AI assisted development.
AGENTS.md+CLAUDE.md. Some concise information about how to build and work with the project. This file was produced during a discussion with Claude where I asked it to write this file and only include those things that it finds useful to be there so that these things can help it work better next time. I don't have any way to measure if this content will actually help or not..mcp.jsonfile that is understood by both Claude and Cursor.