RUM-14720[Guild]: Migrating to unified InternalLoggerUtils#3241
Merged
satween merged 1 commit intoMar 6, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24ce9cfc1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3241 +/- ##
===========================================
+ Coverage 71.49% 71.63% +0.14%
===========================================
Files 934 934
Lines 34628 34641 +13
Branches 5862 5863 +1
===========================================
+ Hits 24755 24814 +59
+ Misses 8231 8209 -22
+ Partials 1642 1618 -24 🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Mar 6, 2026
aleksandr-gringauz
left a comment
aleksandr-gringauz
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement! LGTM.
satween
deleted the
tvaleev/feature/RUM-14720-unified-internal-logger-utils
branch
March 6, 2026 19:06
ncreated
restored the
tvaleev/feature/RUM-14720-unified-internal-logger-utils
branch
April 9, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There was a lot of copied code in the
InternalLoggerUtilsfiles across several modules. Most of it was just handy methods for log verification. This PR consolidates all unique logging verification methods in one place and removes copies from each module.Motivation
Maintaining ~8 files inside each module is not efficient.
testFixturedependency allows to provide same code for all modules.Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)