Skip to content

Use feature flag variant key instead of value for RUM Feature Flag Tracking#3216

Closed
petzel wants to merge 1 commit into
DataDog:developfrom
petzel:eric.petzel/rum-ff-tracking-variant-key
Closed

Use feature flag variant key instead of value for RUM Feature Flag Tracking#3216
petzel wants to merge 1 commit into
DataDog:developfrom
petzel:eric.petzel/rum-ff-tracking-variant-key

Conversation

@petzel

@petzel petzel commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR updates how we Datadog Feature Flags are tracked in RUM, using a variant's key rather than the variant's value.

Motivation

Previously, when using Datadog Feature Flags, the value would be set as the evaluated variant. This is not ideal, particularly when using JSON type flags. JSON flags can be very large, and are not friendly from a UX perspective when typing filters/viewing results. Each variant in a Datadog Feature Flag contains a key, which is a string with a maximum length of 64 characters. This key is better suited for tracking feature flags in RUM.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@petzel
petzel requested review from a team as code owners March 3, 2026 19:22
typotter
typotter approved these changes Mar 3, 2026
View reviewed changes
Comment thread ...d-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/DatadogFlagsClient.kt
trackResolution(flagKey, flag, flagValue, context)
}

private fun parseFlagValueString(flagKey: String, flag: UnparsedFlag): Any {

@typotter typotter Mar 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@petzel
petzel force-pushed the eric.petzel/rum-ff-tracking-variant-key branch from acb7d7a to 9a343eb Compare March 4, 2026 18:59
@petzel

petzel commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-04 22:22:24 UTC ℹ️ Start processing command /merge

2026-03-04 22:22:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-05 02:26:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@petzel
petzel force-pushed the eric.petzel/rum-ff-tracking-variant-key branch from 9a343eb to 428829b Compare March 9, 2026 14:05
@petzel petzel mentioned this pull request Mar 9, 2026
Merged
@0xnm

0xnm commented Mar 10, 2026

Copy link
Copy Markdown
Member

Closing as #3245 is merged.

@0xnm 0xnm closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@typotter typotter typotter approved these changes
@yugisu-flux yugisu-flux yugisu-flux approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petzel @0xnm @typotter @yugisu-flux