RUM-13454: Reverting deprecated classes back to preserve backward compatibility by satween · Pull Request #3215 · DataDog/dd-sdk-android

satween · 2026-03-03T17:52:44Z

What does this PR do?

Reverting some classes back in order of potential backward compatibility breaking changes
Fixes potential issue with buildResourceId method in case if customer will use different versions for okhttp and rum modules.
Fixes one flaky test with HTTP code 408 which lead to produce different behavior between okHttp and Cronet instrumentation

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c758ae64ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov-commenter · 2026-03-03T19:01:14Z

Codecov Report

❌ Patch coverage is 31.11111% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.34%. Comparing base (c217ee7) to head (bbe2a2a).

Files with missing lines	Patch %	Lines
...id/okhttp/internal/utils/SpanSamplingIdProvider.kt	0.00%	7 Missing ⚠️
...datadog/android/okhttp/trace/TracingInterceptor.kt	33.33%	5 Missing and 1 partial ⚠️
...tadog/android/okhttp/internal/OkHttpRequestInfo.kt	68.75%	3 Missing and 2 partials ⚠️
.../android/okhttp/trace/DeterministicTraceSampler.kt	0.00%	5 Missing ⚠️
.../kotlin/com/datadog/android/okhttp/TraceContext.kt	0.00%	4 Missing ⚠️
...a/com/datadog/android/internal/network/HttpSpec.kt	0.00%	2 Missing ⚠️
...om/datadog/android/okhttp/TraceContextInjection.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           release/3.7.0    #3215      +/-   ##
=================================================
- Coverage          71.43%   71.34%   -0.09%     
=================================================
  Files                933      937       +4     
  Lines              34596    34632      +36     
  Branches            5850     5861      +11     
=================================================
- Hits               24711    24707       -4     
- Misses              8245     8280      +35     
- Partials            1640     1645       +5

Files with missing lines	Coverage Δ
...a/com/datadog/android/internal/network/HttpSpec.kt	`86.36% <0.00%> (-2.01%)`	⬇️
...om/datadog/android/okhttp/TraceContextInjection.kt	`0.00% <0.00%> (ø)`
.../kotlin/com/datadog/android/okhttp/TraceContext.kt	`0.00% <0.00%> (ø)`
...tadog/android/okhttp/internal/OkHttpRequestInfo.kt	`81.08% <68.75%> (-10.59%)`	⬇️
.../android/okhttp/trace/DeterministicTraceSampler.kt	`0.00% <0.00%> (ø)`
...datadog/android/okhttp/trace/TracingInterceptor.kt	`82.04% <33.33%> (-1.34%)`	⬇️
...id/okhttp/internal/utils/SpanSamplingIdProvider.kt	`0.00% <0.00%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…patibility

satween · 2026-03-04T14:09:39Z

@chatgpt-codex-connector review
@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ff36dbde2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

0xnm · 2026-03-10T09:48:46Z

+import com.datadog.android.lint.InternalApi
+
+/**
+ * Deprecated. Use com.datadog.android.trace.internal.net.TraceContext instead."


nit: extra " at the end of the sentence.

0xnm · 2026-03-10T09:49:47Z

+ */
+@InternalApi
+@Deprecated(
+    "Use com.datadog.android.trace.internal.net.TraceContext instead.",


We shouldn't propose a class located in the internal package, which is com.datadog.android.trace.internal. Is FQCN correct?

This proposition is not for the customer, but for the developers

0xnm · 2026-03-10T09:50:14Z

-import com.datadog.android.trace.TraceContextInjection
-
 /**
+ * Deprecated. Use [com.datadog.android.trace.TraceContextInjection] instead* with the


extra * in the sentence

0xnm · 2026-03-10T09:51:17Z

+
+private const val HEX_RADIX = 16
+
+// TODO RUM-13454 Remove with SDK v4 release.


This class is internal anyway, why we cannot remove it right now?

satween requested review from a team as code owners March 3, 2026 17:52

chatgpt-codex-connector Bot reviewed Mar 3, 2026

View reviewed changes

Comment thread ...ns/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/TraceContextInjection.kt

This comment has been minimized.

Sign in to view

RUM-14857: Reverting deprecated classes back to preserve backward com…

2ff36db

…patibility

satween force-pushed the tvaleev/feature/RUM-14857 branch from c758ae6 to 2ff36db Compare March 4, 2026 13:39

satween requested a review from 0xnm March 4, 2026 13:44

ambushwork requested changes Mar 4, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/TraceContext.kt Outdated

RUM-14857: Review fixes

bbe2a2a

ambushwork approved these changes Mar 4, 2026

View reviewed changes

satween merged commit 9fbb9f9 into release/3.7.0 Mar 5, 2026
26 checks passed

satween deleted the tvaleev/feature/RUM-14857 branch March 5, 2026 01:18

0xnm reviewed Mar 10, 2026

View reviewed changes


		private const val HEX_RADIX = 16

		// TODO RUM-13454 Remove with SDK v4 release.

Uh oh!

Conversation

satween commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Review checklist (to be filled by reviewers)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment has been minimized.

codecov-commenter commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

satween commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

0xnm Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

satween Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

satween commented Mar 3, 2026 •

edited

Loading

codecov-commenter commented Mar 3, 2026 •

edited

Loading