RUM-12636[Cronet]: Telemetry support#3210
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91862254a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0xnm
requested changes
Mar 2, 2026
satween
force-pushed
the
tvaleev/feature/RUM-12636-telemetry
branch
from
March 2, 2026 15:16
9186225 to
b9f1de4
Compare
0xnm
reviewed
Mar 2, 2026
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3210 +/- ##
===========================================
- Coverage 71.37% 71.35% -0.02%
===========================================
Files 938 938
Lines 34667 34667
Branches 5874 5874
===========================================
- Hits 24743 24735 -8
- Misses 8278 8290 +12
+ Partials 1646 1642 -4
🚀 New features to boost your workflow:
|
satween
force-pushed
the
tvaleev/feature/RUM-12636-telemetry
branch
from
March 2, 2026 17:45
b9f1de4 to
9f84fce
Compare
0xnm
previously approved these changes
Mar 2, 2026
satween
force-pushed
the
tvaleev/feature/RUM-12636-telemetry
branch
3 times, most recently
from
March 6, 2026 13:43
099ec5a to
22fc9dd
Compare
0xnm
previously approved these changes
Mar 10, 2026
satween
force-pushed
the
tvaleev/feature/RUM-12636-telemetry
branch
from
March 10, 2026 17:02
22fc9dd to
cc4ac84
Compare
0xnm
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cronetintegration. (OkHttp will be added in a separate PR.)DatadogSingletonTestConfigurationinto thedd-sdk-android-core's fixtures and reused it across the entire project. This changewas necessary to avoid duplicating
DatadogSingletonTestConfigurationfordd-sdk-android-cronet.Motivation
Measure the adoption rate of the Cronet library among users and compare it with OkHttp.
Review checklist (to be filled by reviewers)