Skip to content

Lower layoutNodeUtils telemetry to warning with callsite information#3208

Merged
ambushwork merged 1 commit into
developfrom
yl/lower-compose-reflection-error
Mar 2, 2026
Merged

Lower layoutNodeUtils telemetry to warning with callsite information#3208
ambushwork merged 1 commit into
developfrom
yl/lower-compose-reflection-error

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

This PR lowers the telemetry error to warnings in layoutNodeUtils but adds more information about the caller

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.49%. Comparing base (2f3dca2) to head (bafb02a).

Files with missing lines Patch % Lines
.../android/compose/internal/utils/LayoutNodeUtils.kt 71.43% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3208      +/-   ##
===========================================
+ Coverage    71.40%   71.49%   +0.09%     
===========================================
  Files          933      933              
  Lines        34580    34580              
  Branches      5847     5847              
===========================================
+ Hits         24689    24720      +31     
+ Misses        8248     8225      -23     
+ Partials      1643     1635       -8     
Files with missing lines Coverage Δ
.../android/compose/internal/utils/LayoutNodeUtils.kt 73.68% <71.43%> (+1.75%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review March 2, 2026 13:29
@ambushwork
ambushwork requested review from a team as code owners March 2, 2026 13:29
0xnm
0xnm previously approved these changes Mar 2, 2026
@ambushwork
ambushwork force-pushed the yl/lower-compose-reflection-error branch from bafb02a to 716c22f Compare March 2, 2026 15:23
@ambushwork
ambushwork requested a review from 0xnm March 2, 2026 15:25
@ambushwork
ambushwork merged commit 5e1d6b3 into develop Mar 2, 2026
26 checks passed
@ambushwork
ambushwork deleted the yl/lower-compose-reflection-error branch March 2, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants