PANA-5681: Add HeatmapIdentifier infrastructure [1 of 4]#3202
Merged
jonathanmos merged 6 commits intoMay 13, 2026
Conversation
This was referenced Feb 27, 2026
gonzalezreal
marked this pull request as ready for review
February 27, 2026 10:39
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cebbd7bc94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ambushwork
reviewed
Feb 27, 2026
0xnm
requested changes
Mar 2, 2026
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
I went only through the production source files so far and left some comments.
…eal/PANA-5681/view-identity-resolver
jonathanmos
marked this pull request as draft
May 5, 2026 09:59
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/heatmaps #3202 +/- ##
====================================================
+ Coverage 71.99% 72.06% +0.06%
====================================================
Files 961 964 +3
Lines 35401 35429 +28
Branches 5876 5880 +4
====================================================
+ Hits 25486 25529 +43
+ Misses 8301 8285 -16
- Partials 1614 1615 +1
🚀 New features to boost your workflow:
|
jonathanmos
changed the title
ViewIdentityResolver infrastructureViewIdentityResolver infrastructure [1 of 4]
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/view-identity-resolver
branch
from
May 6, 2026 10:36
e4607af to
6b5f91a
Compare
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/view-identity-resolver
branch
from
May 7, 2026 09:34
6b5f91a to
3e2c2ab
Compare
jonathanmos
marked this pull request as ready for review
May 7, 2026 12:16
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e2c2ab8a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0xnm
reviewed
May 7, 2026
ambushwork
reviewed
May 7, 2026
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/view-identity-resolver
branch
from
May 11, 2026 08:32
7451809 to
77957a4
Compare
jonathanmos
changed the title
ViewIdentityResolver infrastructure [1 of 4]HeatmapIdentifier infrastructure [1 of 4]
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/view-identity-resolver
branch
from
May 11, 2026 11:43
77957a4 to
ec32d76
Compare
ambushwork
previously approved these changes
May 11, 2026
0xnm
previously approved these changes
May 11, 2026
0xnm
approved these changes
May 13, 2026
ambushwork
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces the foundational shared component for mobile heatmaps: a
HeatmapIdentifierRegistryin the internal module that Session Replay writes to and RUM reads from. The store holds an atomic snapshot of view identities (keyed by view ID) that SR publishes after each window traversal; RUM's gesture listener will then look up the identifier for a tapped view and, if found, attaches it alongside the view's dimensions and touch position to the action event. The implementation uses a ReentrantReadWriteLock so SR's writes (full snapshot replacement) never block concurrent RUM reads.This PR introduces only the data contracts (HeatmapIdentifier, HeatmapIdentifierRegistry, HeatmapIdentifierStore) in dd-sdk-android-internal. The cross-feature wiring will follow in the rum-heatmaps PR: a new HeatmapsFeature : Feature will live in dd-sdk-android-rum, hold a HeatmapIdentifierRegistry, and be registered on SdkCore by RumFeature during initialization — mirroring how SessionReplayFeature registers its sibling ResourcesFeature. Session Replay will then read the registry via sdkCore.getFeature(HEATMAPS_FEATURE_NAME), matching the iOS architecture (where HeatmapIdentifierRegistryFeature is registered on the core and consumed by SR through the same lookup path). The companion factory HeatmapIdentifierRegistry.create() stays in this PR as the constructor seam that lets HeatmapsFeature build a registry without exposing HeatmapIdentifierStore outside dd-sdk-android-internal.
Motivation
Support mobile heatmaps. This is PR 1 of 4, the foundational infrastructure that RUM and Session Replay will build on.
Additional Notes
Ported from #3164. Self-contained with no dependency on schema changes.
Review checklist (to be filled by reviewers)