Skip to content

Close precomputed assignments response body#3198

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/close-precomputed-assignments-response-body
Feb 24, 2026
Merged

Close precomputed assignments response body#3198
0xnm merged 1 commit into
developfrom
nogorodnikov/close-precomputed-assignments-response-body

Conversation

@0xnm

@0xnm 0xnm commented Feb 24, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Response.body should be closed after being read.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner February 24, 2026 08:02
@0xnm
0xnm requested a review from typotter February 24, 2026 08:02
@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.35%. Comparing base (63dfac8) to head (8a7397c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3198      +/-   ##
===========================================
+ Coverage    71.28%   71.35%   +0.06%     
===========================================
  Files          928      928              
  Lines        34441    34441              
  Branches      5811     5811              
===========================================
+ Hits         24551    24572      +21     
+ Misses        8259     8230      -29     
- Partials      1631     1639       +8     
Files with missing lines Coverage Δ
...s/internal/net/PrecomputedAssignmentsDownloader.kt 100.00% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 18b420c into develop Feb 24, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/close-precomputed-assignments-response-body branch February 24, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants