Skip to content

Update RUM schema#3193

Merged
kikoveiga merged 3 commits into
developfrom
kikoveiga/clone-rum-schema
Feb 20, 2026
Merged

Update RUM schema#3193
kikoveiga merged 3 commits into
developfrom
kikoveiga/clone-rum-schema

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Feb 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Runs cloneRumSchema Gradle task.
  • Runs generateRumModelsFromJson Gradle task.
  • Fixes some code related to view now being a non-nullable in VitalAppLaunchEvent (changes in _common-schema.json).

Motivation

Get the latest changes from resource-schema.json with the new request and response properties needed for the Network Headers capture.

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga
kikoveiga marked this pull request as ready for review February 19, 2026 17:39
@kikoveiga
kikoveiga requested a review from a team as a code owner February 19, 2026 17:39
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 19, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d61f99b08b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread features/dd-sdk-android-rum/src/main/json/rum/_common-schema.json
"type": "object",
"description": "Schema of common properties of RUM events",
"required": ["date", "application", "session", "_dd"],
"required": ["date", "application", "session", "view", "_dd"],

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep view optional in common schema

Making view globally required in the shared RUM schema breaks app-launch vitals that are emitted before the first view is established: RumVitalAppLaunchEventHelper explicitly sets view to null when rumContext.viewId/viewUrl are missing, so after model regeneration this change makes VitalAppLaunchEvent.view non-null and the helper no longer type-checks (or those events fail validation if generation is skipped).

Useful? React with 👍 / 👎.

@kikoveiga kikoveiga self-assigned this Feb 19, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch from 25bb63a to 0da2f44 Compare February 19, 2026 18:37
@kikoveiga
kikoveiga marked this pull request as draft February 19, 2026 18:37
@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch 2 times, most recently from 890ac78 to 6c01f83 Compare February 19, 2026 19:02
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Feb 19, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 66.50% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b70a733 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Feb 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.27%. Comparing base (699dce4) to head (b70a733).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
+ Coverage    71.26%   71.27%   +0.02%     
===========================================
  Files          929      929              
  Lines        34442    34438       -4     
  Branches      5813     5814       +1     
===========================================
+ Hits         24542    24545       +3     
+ Misses        8255     8254       -1     
+ Partials      1645     1639       -6
Files with missing lines Coverage Δ
...ernal/domain/scope/RumVitalAppLaunchEventHelper.kt 89.58% <100.00%> (+0.58%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch 2 times, most recently from d9d44c8 to 7816abe Compare February 20, 2026 10:14
kikoveiga
kikoveiga commented Feb 20, 2026
View reviewed changes
Comment thread ...rc/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumVitalAppLaunchEventHelper.kt
Comment on lines +66 to +68
id = rumContext.viewId ?: RumContext.NULL_UUID,
referrer = null,
url = rumContext.viewUrl ?: "",

@kikoveiga kikoveiga Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is aligned with iOS: https://github.com/DataDog/dd-sdk-ios/blob/f75922d5bbe026405641c9fad4633ce5261faa3b/DatadogRUM/Sources/RUMMonitor/Scopes/RUMAppLaunchManager.swift#L206-L208

@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch from 7816abe to 6468260 Compare February 20, 2026 10:28
@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch from 6468260 to 5cbb9a0 Compare February 20, 2026 10:37
@kikoveiga
kikoveiga marked this pull request as ready for review February 20, 2026 10:38
0xnm
0xnm requested changes Feb 20, 2026
View reviewed changes
Comment thread features/dd-sdk-android-rum/src/main/json/rum/transition-schema.json Outdated
Comment thread features/dd-sdk-android-rum/src/main/json/rum/_view-performance-schema.json Outdated
Comment thread features/dd-sdk-android-rum/src/main/json/rum/_stream-schema.json Outdated
Comment thread features/dd-sdk-android-rum/src/main/json/rum/_common-schema.json Outdated
@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch 3 times, most recently from f7c3d69 to 2df802f Compare February 20, 2026 15:16
0xnm
0xnm previously approved these changes Feb 20, 2026
View reviewed changes
@kikoveiga
kikoveiga force-pushed the kikoveiga/clone-rum-schema branch from 2df802f to b70a733 Compare February 20, 2026 15:28
@kikoveiga
kikoveiga merged commit f5455c8 into develop Feb 20, 2026
26 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/clone-rum-schema branch February 20, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz left review comments

Assignees

@kikoveiga kikoveiga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kikoveiga @codecov-commenter @0xnm @aleksandr-gringauz